fboss2: remove no-op lrint in splitFractionalSecondsFromTimer#1294
Open
atulya-singh wants to merge 1 commit into
Open
fboss2: remove no-op lrint in splitFractionalSecondsFromTimer#1294atulya-singh wants to merge 1 commit into
atulya-singh wants to merge 1 commit into
Conversation
tv.tv_usec is a long that was just assigned an integer (timer % 1000), so lrint() on it is a no-op and the "round fs to nearest decimal" comment is misleading -- there is nothing fractional to round. Drop the line and fix the comment to note the value is milliseconds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-submission checklist
pip install -r requirements-dev.txt && pre-commit installpre-commit runSummary
In
splitFractionalSecondsFromTimer(fboss/cli/fboss2/utils/CmdUtilsCommon.cpp):tv.tv_usecis alongthat was just assigned the integer result oftimer % 1000. Callinglrint()on an already-integral value is a no-op, and the "round fs to nearest decimal" comment is misleading -- there is nothing fractional to round.This change removes the dead line and corrects the comment to note the value is milliseconds (it is the
timer % 1000remainder, not microseconds despite thetv_usecfield name).Test Plan
Pure cleanup with no behavioral change.
pre-commit run --files fboss/cli/fboss2/utils/CmdUtilsCommon.cpp->clang-format ... Passed, all hooks pass.timer = 6475still yields{tv_sec = 6, tv_usec = 475}, whichparseTimeToTimeStampcontinues to render identically.