[Celestica] Icecube: Config: Add TRVDD sensor support for SMB v3.3.10#1320
Open
zhongedward wants to merge 1 commit into
Open
[Celestica] Icecube: Config: Add TRVDD sensor support for SMB v3.3.10#1320zhongedward wants to merge 1 commit into
zhongedward wants to merge 1 commit into
Conversation
Contributor
|
@mikechoifb has imported this pull request. If you are a Meta employee, you can view this in D109721726. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-submission checklist
pip install -r requirements-dev.txt && pre-commit installpre-commit runSummary
As part of the Icecube PVT process, new SMB (System Main Board) units have been manufactured with version combination 3.3.10 (productionState: 3, productionSubState: 3, respinVariantIndicator: 10).
This PR adds the necessary sensor configuration block in
sensor_service.jsonto support these new units. Without this change, thesensor_servicewould fail to correctly associate and monitor the voltage rails for this specific hardware revision.The update specifically includes VOUT monitoring for the four SMB TRVDD rails (Phase 0-3), mapped to
in4_inputon their respective voltage monitor chips:SMB_XP0R72V_PB_TRVDD_0_VOUT->SMB_ASIC_VOLTAGE_0SMB_XP0R72V_PB_TRVDD_1_VOUT->SMB_ASIC_VOLTAGE_6SMB_XP0R72V_PB_TRVDD_2_VOUT->SMB_ASIC_VOLTAGE_3SMB_XP0R72V_PB_TRVDD_3_VOUT->SMB_ASIC_VOLTAGE_7Test Plan
Syntax Validation: Validated JSON syntax.
Formatting: Pretty-printed configurations using the
jqcommand for readability.Build & Config Tests: Compilation and configuration validation tests passed successfully.
Service Verification: Confirmed that the following services start and run without errors:
platform_managersensor_service/sensor_service_client/sensor_service_sw_test/sensor_service_hw_testHardware Identification: Verified the SMB version (3.3.10) is correctly identified via FRU/EEPROM utility during initial bring-up.
Voltage Audit: Confirmed TRVDD voltage readings are within the nominal 0.72V range (verified via
sensor_service_client).icecube_platform_service_2026_06_22_log.txt
icecube_sensor_service_2026_06_22_log.txt
icecube_sensor_service_client_2026_06_22_log.txt
icecube_sensor_service_hw_test_2026_06_22_log.txt
icecube_sensor_service_sw_test_2026_06_22_log.txt