[Nexthop][PlatformManager][M4062NHP] Support AMD CPU i2c buses C and D#1330
Closed
anna-nexthop wants to merge 2 commits into
Closed
[Nexthop][PlatformManager][M4062NHP] Support AMD CPU i2c buses C and D#1330anna-nexthop wants to merge 2 commits into
anna-nexthop wants to merge 2 commits into
Conversation
@3) **Pre-submission checklist** - [x] I've ran the linters locally and fixed lint errors related to the files I modified in this PR. You can install the linters by running `pip install -r requirements-dev.txt && pre-commit install` - [x] `pre-commit run` Map the AMD i2c controllers I2CC and I2CD to CPU_BUS@2 and CPU_BUS@3 in I2cExplorer (index-aligned to the AMD i2c[N] controllers; the legacy I2CA/I2CB mapping is unchanged), and widen ConfigValidator to accept CPU_BUS@0 through CPU_BUS@3 in i2cAdaptersFromCpu. This lets a platform_manager.json model devices on the third and fourth CPU-direct i2c buses. Running the config_validator_test which now verifies CPU_BUS@[0-3] are valid while anything past that index is invalid.
2 tasks
anna-nexthop
changed the title
Contributor
|
@somasun has imported this pull request. If you are a Meta employee, you can view this in D110123451. |
somasun
requested changes
Jun 30, 2026
Follow-up to address review feedback on expanding CPU bus usage: - Update PlatformConfig.i2cAdaptersFromCpu Thrift docs to describe the full AMD virtual CPU bus mapping, consistent with kAmdAcpiPathToBusIndex in I2cExplorer (CPU_BUS@0..3 -> I2CB/I2CA/I2CC/I2CD). - Add an explicit runtime check in I2cExplorer::resolveIntelCpuBusNums so that Intel platforms fail gracefully with a clear message when i2cAdaptersFromCpu is anything other than a single CPU_BUS@0 entry. - Add IntelCpuBusConfigValidation unit test covering the invalid Intel virtual CPU bus configurations.
|
@anna-nexthop has updated the pull request. You must reimport the pull request before landing. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-submission checklist
pip install -r requirements-dev.txt && pre-commit installpre-commit runSummary
Map the AMD i2c controllers I2CC and I2CD to CPU_BUS@2 and CPU_BUS@3 in I2cExplorer (index-aligned to the AMD i2c[N] controllers; the legacy I2CA/I2CB mapping is unchanged), and widen ConfigValidator to accept CPU_BUS@0 through CPU_BUS@3 in i2cAdaptersFromCpu. This lets a platform_manager.json model devices on the third and fourth CPU-direct i2c buses.
Test Plan
Running the config_validator_test which now verifies CPU_BUS@[0-3] are valid while anything past that index is invalid.