[Celestica] Tahansb: fan_service: Fixing OTP issues by optimizing the OTP algorithm#1338
Open
QiuyunXie wants to merge 1 commit into
Open
[Celestica] Tahansb: fan_service: Fixing OTP issues by optimizing the OTP algorithm#1338QiuyunXie wants to merge 1 commit into
QiuyunXie wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-submission checklist
pip install -r requirements-dev.txt && pre-commit installpre-commit runSummary
Meta reported a TH6 PCIe link issue, which, after debugging, was found to be caused by an SW OTP. It appears that during the TH6 SDK/agent initialization process, the TH6_TEMP sensor reads an abnormal, untrustworthy temperature jump. This anomalous reading value should not be used to trigger OTP.
The OTP algorithm has been optimized. The previous algorithm, which calculated the average of windowsize TH6 temperature samples to determine OTP, was a bit unreasonable. When an abnormally high temperature value is read within the window size, the calculated average will still remain high enough to exceed the overtemp threshold. It has been replaced with an algorithm that requires the TH6 temperature to exceed the overtempThreshold for windowsize consecutive samples before triggering OTP.
Test Plan
Continuously execute the agent initialization stress test while simultaneously running platform_manager, sensor_service, and fan_service.
Our SVT team has been running the stress test continuously for a week, and the issue has not been reproduced.