[Nexthop][NPI] "asic_config_v3" - Add ladakh800bcls platform and its variants#1341
Open
marif-nexthop wants to merge 1 commit into
Open
[Nexthop][NPI] "asic_config_v3" - Add ladakh800bcls platform and its variants#1341marif-nexthop wants to merge 1 commit into
marif-nexthop wants to merge 1 commit into
Conversation
Implements `asic_config_v3` design. In this PR, add platform configurations for `ladakh800bcls`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-submission checklist
pip install -r requirements-dev.txt && pre-commit installpre-commit runSummary
Implements
asic_config_v3design.In this PR, add platform configurations for the
rackandtest_fixturevariants ofladakh800bclsplatform.After this commit the
asic_config_v3generator produces the following extra output filesfboss/lib/asic_config_v3/generated_asic_configs/ladakh800bcls_rack.ymlfboss/lib/asic_config_v3/generated_asic_configs/ladakh800bcls_test_fixture.ymlTest Plan
The generated output files are compared against the
asic_config_v2synced configs. Both variants show the same small set of differences:The differences are limited to ordering of keys in the global
devicetable (the SDK does not depend on this order) and a few keys (l3_ecmp_member_*,dlb_quality_adjustment_default_value_select, and theDLB_ECMP_CONFIGblock) that are only present in the staleasic_config_v2synced configs. These differences are expected.This PR depends on (and should land after) the following PR:
The
rackandtest_fixturevariants setplatform_mapping_nameto target siblingplatform_mapping_v2directories; the generator support forplatform_mapping_nameis introduced in #1242.