[Celestica] Icecubem: Config: Introduce icecubem platform configs for Netlake2.0#1352
Draft
zhongedward wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-submission checklist
pip install -r requirements-dev.txt && pre-commit installpre-commit runSummary
This PR implements and brings up the initial
icecubemplatform configurations for Netlake 2.0 by leveraging and extending the topology baselines from the existingicecubeplatform heritage.Key Changes
1. Platform Manager (
platform_manager)platform_manager_validators.thriftto supportICECUBEM_MCBand register theicecubemasset token within theALLOWED_PMUNIT_NAMESlist.CPU_BUS.pmUnitConfigsandversionedPmUnitConfigsengines specialized forNETLAKE20board tracking.symbolicLinkToDevicePathconfigurations and sysfs discovery paths to fully align with the newNETLAKE20I2C switch topology routing.2. Sensor Service (
sensor_service)NETLAKE20sensor dictionary profiles, monitoring thresholds, and platform-specific sysfs paths to support the redesigned physical layout.3. Firmware Utility (
fw_util)fw_utilaction blueprint for BIOS upgrades to properly orchestrateNETLAKE20specific flash sequences.flashrombin utility needs to explicitly support the AMD secure boot BIOS upgrade sequence; the corresponding package update patch will be pushed independently to the BSP tracking repository.4. BSP Tests (
bsp_tests)bsp_tests.jsonconfig map to enable full test matrix harness support for theicecubemasset class.5. Config Adjustments & Retained Profiles
fan_service.json): Updated the sensor name alignment fromCPU_UNCORE_TEMPtoCOME_U1_CPU_UNCORE_TEMPto fully match the revised sysfs telemetry naming standard on Netlake 2.0. The PID settings (kp,ki,kd) and pwm threshold behaviors remain unchanged.led_manager.jsonandrma_showtech.json.Test Plan
Platform Services build validation and schema verification have successfully passed with zero compiler warnings.
The comprehensive target validation covered the following engineering criteria (all results returned PASS):
The complete test execution tracker and comprehensive diagnostic log files are securely archived here:
Google Drive: icecubem_netlake2.0_before_bringup_fboss_test