Added queue 7 to pump traffic#375
Conversation
|
Hi @rakhmatoveradzh! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
…ok#375) The default Git diff algorithm doesn't produce the best diffs and `zdiff3` reduces the size of the conflicts.
2 participants
The test was failing because PFC wasn't being triggered. The reason was we were dropping packets which prevented us from reaching PFC threshold.
I discovered that the queue from which we are injecting packets gets stale. Root cause is because we had strict priority scheduler applied, higher indexed queues have a higher priority than lower indexed queues. And because we weren't specifying which queue to send packets to, we were defaulting to queue 0 which has the lowest priority and therefore packets from there would never be send to the destination queue.
The fix is to explicitly send to queue 7.