Janga: config: Adjusted tmp422 sensor position to support 2nd and main source machine

[joywu-coder]

Description

This PR is about tmp422 sensors in the Janga platform config file and sensor config file.

Motivation

1. In the current platform config file, tmp422 can only run successfully on the main source machine. The problem was that I put tmp422 on SMB_FRU_SLOT, which can only be loaded successfully on the main source.To resolve this issue, tmp422 needs to be repositioned. In this PR, I moved the tmp422 related parts to JANGA_SLOT, so that it can run successfully on both 2nd source and main source machines.

2. Note: This function has a limitation.The tmp422 sensors are only available in hardware from DVT2 and later. If you run the platform service and sensor service on a machine before this, an error will be reported.

Test Plan

1. The correctness of the format has been verified on this jsonlint website.
2. Used jq command to pretty the format.
3. Test log as follows:

1. In main source machine platform run successfully:

2. In main source machine sensor_service_hw_test run successfully:

3. In 2nd source machine platform run successfully:

4. In 2nd source machine sensor_service_hw_test run successfully:

janga_main_source_platform_test_log_5_14.txt
janga_main_source_sensor_test_log_5_12.txt
janga_2nd_source_platform_test_log_5_12.txt
janga_2nd_source_sensor_test_log_5_12.txt

[facebook-github-bot]

@mikechoifb has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[Scott8440]

Thank you for the PR @joywu-coder. We are seeing merge errors on our side. Can you please rebase onto the latest main commit?

[facebook-github-bot]

@joywu-coder has updated the pull request. You must reimport the pull request before landing.

[facebook-github-bot]

@joywu-coder has updated the pull request. You must reimport the pull request before landing.

[facebook-github-bot]

@joywu-coder has updated the pull request. You must reimport the pull request before landing.

[facebook-github-bot]

@joywu-coder has updated the pull request. You must reimport the pull request before landing.

[facebook-github-bot]

@joywu-coder has updated the pull request. You must reimport the pull request before landing.

[facebook-github-bot]

@joywu-coder has updated the pull request. You must reimport the pull request before landing.

[joywu-coder]

Rebase the code and build.

[facebook-github-bot]

@joywu-coder has updated the pull request. You must reimport the pull request before landing.

[facebook-github-bot]

@joywu-coder has updated the pull request. You must reimport the pull request before landing.

[joywu-coder]

@joywu-coder has updated the pull request. You must reimport the pull request before landing.

@mikechoifb, please reimport the pull request, thanks.

[somasun]

@joywu-coder - Regarding your comment "The problem was that I put tmp422 on SMB_FRU_SLOT, which can only be loaded successfully on the main source." Can you please explain why this is so with more details?

[somasun]

Please add more details in the PR Summary on why this sensor is being moved to a different PmUnit in the config. Is the sensor physically moved in the case of second source ?

[joywu-coder]

Please add more details in the PR Summary on why this sensor is being moved to a different PmUnit in the config. Is the sensor physically moved in the case of second source ?
@somasun Thanks for your comments. Actually, the TMP422 sensor is a public device and does not have a second source. The incorrect configuration that placed the TMP422 sensor in the SMB_SLOT version caused it to fail to load. We now move the TMP422 config into the common JANGA_SLOT. @clslucas will send the email for the detailed clarification.

[clslucas]

@somasun @mikechoifb Regarding this PR I wrote an email "[FBOSS] Minerva Janga PR#442 Confusion and TMP422 limitations" to clarify this case.
1.Maybe the PR title description confused you, the config file was updated because the TMP422 sensor is a common device, in the previous config file we assigned the tmp422 configuration to the main source through the 'pmUnitConfigs' field, but it is not a second source device, so through this PR we move the TMP422 configuration file to the generic JANGA_SLOT.
2.We know that the TMP422 device monitors the temperature of the J3 ASIC through the BJT for the OTP feature, but due to hardware limitation, the TMP422 can only work properly starting from the DVT2 stage, so the fboss platform manager will report a problem that the tmp422 cannot be found when running on previous DVT2 devices.

[facebook-github-bot]

@joywu-coder has updated the pull request. You must reimport the pull request before landing.

[somasun]

@somasun @mikechoifb Regarding this PR I wrote an email "[FBOSS] Minerva Janga PR#442 Confusion and TMP422 limitations" to clarify this case. 1.Maybe the PR title description confused you, the config file was updated because the TMP422 sensor is a common device, in the previous config file we assigned the tmp422 configuration to the main source through the 'pmUnitConfigs' field, but it is not a second source device, so through this PR we move the TMP422 configuration file to the generic JANGA_SLOT. 2.We know that the TMP422 device monitors the temperature of the J3 ASIC through the BJT for the OTP feature, but due to hardware limitation, the TMP422 can only work properly starting from the DVT2 stage, so the fboss platform manager will report a problem that the tmp422 cannot be found when running on previous DVT2 devices.

Thanks for the explanation @joywu-coder and @clslucas

[facebook-github-bot]

@joywu-coder has updated the pull request. You must reimport the pull request before landing.

[facebook-github-bot]

@mikechoifb merged this pull request in 54f38c3.