MERU800BIA/BFA: Initialize PSUs with write-protect#474
Open
aalamsi22 wants to merge 3 commits into
Open
Conversation
Contributor
|
@aalamsi22 Does this PR change require BSP version 0.7.10 ? I am just trying to understand if the same comments in #441 also apply to it. |
Contributor
Author
No, this is independent of the bsp. |
Contributor
|
@joancaneus has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
aalamsi22
force-pushed
the
meru_pmbus_wp
branch
from
880dc7c to
45253ad
Compare
Contributor
|
@aalamsi22 has updated the pull request. You must reimport the pull request before landing. |
Contributor
|
@joancaneus has imported this pull request. If you are a Meta employee, you can view this in D76944650. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Some registers when read, cause the psu to raise an error through the status_cml register at 0x7e. This is normal for some PSUs with unsupported registers. However, problems arise when the write-protect is disabled, the linux pmbus driver sees the status register reporting an error and decides to ignore the valid values it reads.
Motivation
While this issue shouldn't hit because the WP register is enabled by default when the PSU turns on, this change ensures that WP is enabled in the rare cases where a WP may have been disabled manually or by another process prior to setting up fboss on the system.
Testing
Manually disabled WP and confirmed platform manager enables it again. All expected psu sensors are read successfully.