Icetea: config: platform service configurations support for EVT1#484
Icetea: config: platform service configurations support for EVT1#484joywu-coder wants to merge 17 commits into
Conversation
|
@mikechoifb has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@joywu-coder has updated the pull request. You must reimport the pull request before landing. |
|
@joywu-coder has updated the pull request. You must reimport the pull request before landing. |
|
@joywu-coder has updated the pull request. You must reimport the pull request before landing. |
|
@joywu-coder has updated the pull request. You must reimport the pull request before landing. |
|
@joywu-coder has updated the pull request. You must reimport the pull request before landing. |
|
@joywu-coder has updated the pull request. You must reimport the pull request before landing. |
joywu-coder
changed the title
@mikechoifb Please import this PR, thanks. |
| "SMBus I801 adapter at 5000", | ||
| "SMBus iSMT adapter at 20fffa7b000" | ||
| ], | ||
| "versionedPmUnitConfigs": { |
There was a problem hiding this comment.
Why do we have versionedPmUnitConfigs for NETLAKE PmUnit? Considering the hardware is not there yet, how are we already having multiple versions? .. hmmm
There was a problem hiding this comment.
@somasun , NetLake is a common building block (COMe) used by most of NPI projects. We are going to use NetLake version .2 for this project. (As of now.)
There was a problem hiding this comment.
We have two NETLAKE PmUnit configs in this PR. One is version 2, and another is default. If we are going to use version 2, why not make it the default?
There was a problem hiding this comment.
@joywu-coder , can you remove the Netlake version config that restrics Netlake version to "2" only?
There was a problem hiding this comment.
@joywu-coder , can you remove the Netlake version config that restrics Netlake version to "2" only?
@mikechoifb @somasun Got it, thanks for your comments, Lucas has been clarifying this issue by email "Config for versions of NETLAKE(COMe) in fboss PRs"
There was a problem hiding this comment.
@joywu-coder It's been a while... Can we make Netlake config as just regular config and NOT versioned config?
There was a problem hiding this comment.
Sure, I have completed the update. Thank you!
There was a problem hiding this comment.
@somasun @mikechoifb Please review this PR again, we have updated the COMe configuration, thank you!
|
@joywu-coder has updated the pull request. You must reimport the pull request before landing. |
|
@joywu-coder has updated the pull request. You must reimport the pull request before landing. |
|
@joywu-coder has updated the pull request. You must reimport the pull request before landing. |
|
@joywu-coder has updated the pull request. You must reimport the pull request before landing. |
|
@joywu-coder has updated the pull request. You must reimport the pull request before landing. |
|
@joywu-coder has updated the pull request. You must reimport the pull request before landing. |
|
@somasun @mikechoifb Please review this PR again, we have updated the COMe configuration, thank you! |
|
@mikechoifb has imported this pull request. If you are a Meta employee, you can view this in D77387924. |
|
@mikechoifb merged this pull request in 303c1f3. |
5 participants
Description
FBOSS platform service configurations support for the EVT1 phase.
Motivation
Based on the Icetea EVT1 hardware specifications, the preliminary version configurations of platform_manager, fw_util, weutil, sensor_service, led_manager, and fan_service are provided for the EVT1 phase.
We currently lack physical devices for testing, meaning that the configs have not yet been verified on actual hardware. However, Fboss compilation and config cross-check are passed.
Test Plan
Build_fboss_platform_services_log.txt