Update SCM Sensors#579
Closed
pawagh1 wants to merge 1 commit into
Closed
Conversation
|
Hi @pawagh1! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
meta-codesync Bot
pushed a commit
that referenced
this pull request
Feb 19, 2026
Summary: **Pre-submission checklist** - [x] I've ran the linters locally and fixed lint errors related to the files I modified in this PR. You can install the linters by running `pip install -r requirements-dev.txt && pre-commit install` - [x] `pre-commit run` When building only a specific cmake target to save time, getdeps removes the "built marker” under `$builddir/installed/fboss/.built-by-getdeps`, which makes it impossible to subsequently run the unit tests as without this file getdeps bails out with `project fboss has not been built`. What’s more, because of a missing `return` the exit code was 0, which was confusing. This fix ensures that the return code is propagated properly and also improves the cmake test runner to automatically detect missing executables and build them on the fly. This will not rebuild the test binaries if they've already been built and are merely stale (because the source code has changed) but that was already the prior behavior. At least now it's possible to rebuild a single cmake test target and re-run the tests in one shot. Pull Request resolved: #722 Test Plan: - Manually removed one unit test target, running `getdeps.py test` now can detect the missing test executables, and then rebuild such executables before running the tests ``` [root@5f196107a3a6 fboss]# ls -al /var/FBOSS/tmp_bld_dir/build/fboss/fboss2_cmd_test -rwxr-xr-x 1 root root 116548584 Feb 17 20:48 /var/FBOSS/tmp_bld_dir/build/fboss/fboss2_cmd_test [root@5f196107a3a6 fboss]# rm -rf /var/FBOSS/tmp_bld_dir/build/fboss/fboss2_cmd_test [root@5f196107a3a6 fboss]# ./build/fbcode_builder/getdeps.py test --allow-system-packages --extra-cmake-defines='{"CMAKE_BUILD_TYPE": "MinSizeRel", "CMAKE_CXX_STANDARD": "20"}' --scratch-path /var/FBOSS/tmp_bld_dir --num-jobs 16 --src-dir . fboss Testing ENV[BOOST_ROOT_1_69_0]: None Building missing test executables: fboss2_cmd_test ... + cd /var/FBOSS/tmp_bld_dir/build/fboss && \ + /usr/bin/cmake \ + --build \ + /var/FBOSS/tmp_bld_dir/build/fboss \ + --target \ + fboss2_cmd_test \ + --config \ + RelWithDebInfo \ + -j \ + 16 [1/1] Linking CXX executable fboss2_cmd_test --- ... 103/689 Test #110: CmdShowAggregatePortTestFixture.queryClient ...................................................................................................... Passed 0.10 sec Start 141: CmdShowRouteDetailsTestFixture.queryClient 104/689 Test #113: CmdShowExampleTestFixture.queryClient ............................................................................................................ Passed 0.09 sec Start 94: CmdShowArpTestFixture.queryClient 105/689 Test #126: CmdShowInterfaceErrorsTestFixture.queryClient .................................................................................................... Passed 0.10 sec Start 87: CmdSetPortStateTestFixture.enableOnePort 106/689 Test #129: CmdShowMirrorTestFixture.queryClientWithoutTunnel ................................................................................................ Passed 0.10 sec Start 123: CmdShowInterfaceCountersTestFixture.queryClient ... 100% tests passed, 0 tests failed out of 689 Total Test time (real) = 20.93 sec ``` - Confirmed the test executable was actually build, noticed timestamp of such binary is different than before ``` [root@5f196107a3a6 fboss]# ls -al /var/FBOSS/tmp_bld_dir/build/fboss/fboss2_cmd_test -rwxr-xr-x 1 root root 116548584 Feb 17 22:26 /var/FBOSS/tmp_bld_dir/build/fboss/fboss2_cmd_test ``` - Now run the test command again when all the test binaries exist without any issue ``` [root@5f196107a3a6 fboss]# ./build/fbcode_builder/getdeps.py test --allow-system-packages --extra-cmake-defines='{"CMAKE_BUILD_TYPE": "MinSizeRel", "CMAKE_CXX_STANDARD": "20"}' --scratch-path /var/FBOSS/tmp_bld_dir --num-jobs 16 --src-dir . fboss Testing ENV[BOOST_ROOT_1_69_0]: None --- ... 686/689 Test #578: ThriftStructNodeTestSuite.ThriftStructNodeRemovePathOnThriftMapTest<TestParams<true>> ............................................................ Passed 0.01 sec 687/689 Test #579: ThriftStructNodeTestSuite.ThriftStructNodeRemovePathOnThriftListTest<TestParams<true>> ........................................................... Passed 0.01 sec 688/689 Test #580: ThriftStructNodeTestSuite.ThriftStructNodeRemovePathOnThriftSetTest<TestParams<true>> ............................................................ Passed 0.01 sec 689/689 Test #550: ThriftStructNodeTests.ThriftStructNodeSetAlreadyPublished ........................................................................................ Passed 0.18 sec 100% tests passed, 0 tests failed out of 689 Total Test time (real) = 21.00 sec ``` Reviewed By: bigfootjon Differential Revision: D93524014 Pulled By: joseph5wu fbshipit-source-id: d58055430e181f4efa6901985b7b2e7de4626a11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.