[bsp_tests] Bind desiredDrivers when reloading kmods#626
Open
dzarista wants to merge 1 commit into
Open
Conversation
Contributor
|
@Scott8440 has imported this pull request. If you are a Meta employee, you can view this in D86276834. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
During bsp_tests, before each subtest, kmods are reloaded. This poses an issue for devices that need to use the desiredDriver setting, as loading the scd driver will not actually bind the devices.
To fix this, I'm proposing a change similar to the way PciExplorer handles desiredDriver. In KmodUtils, the desiredDriver attribute is checked and the devices are bound during runtime.
Test Plan
bsp_tests passes on darwin(48v), which use desiredDriver for scd devices.