Initial Configuration for Wedge800CACT Platform Manager#648
Initial Configuration for Wedge800CACT Platform Manager#648brandonchuang wants to merge 1 commit into
Conversation
| "address": "0x54", | ||
| "kernelDeviceName": "24c02" | ||
| }, | ||
| "pmUnitName": "MCB" |
There was a problem hiding this comment.
Please remove the "pmUnitName" names from all slotTypeConfigs. Since the EEPROM's ProductName field is programmed correctly, this should not be required.
There was a problem hiding this comment.
Please remove the "pmUnitName" names from all slotTypeConfigs. Since the EEPROM's ProductName field is programmed correctly, this should not be required.
@somasun
Could we keep that part? We need pmUnitName when the EEPROM is present but still empty (before the ProductName is programmed). Without pmUnitName, the system cannot bring up the associated CPLD device, and therefore cannot disable the CPLD write-protect. This makes the initial EEPROM provisioning process very difficult.
| "address": "0x54", | ||
| "kernelDeviceName": "24c64" | ||
| }, | ||
| "pmUnitName": "SCM" |
| "address": "0x51", | ||
| "kernelDeviceName": "24c64" | ||
| }, | ||
| "pmUnitName": "BMC" |
| "address": "0x50", | ||
| "kernelDeviceName": "24c64" | ||
| }, | ||
| "pmUnitName": "SMB" |
| }, | ||
| "FAN_SLOT": { | ||
| "numOutgoingI2cBuses": 0, | ||
| "pmUnitName": "FAN" |
| "address": "0x37", | ||
| "kernelDeviceName": "adc128d818", | ||
| "pmUnitScopedName": "MCB_VOLTAGE_MONITOR5", | ||
| "initRegSettings": [ |
There was a problem hiding this comment.
Please add a __comment__ on why this i2cset is needed for this device.
There was a problem hiding this comment.
MCB_VOLTAGE_MONITOR5 only uses IN0–IN5, so Mode 1 is not needed. I’ve removed the initRegSettings for this device. Please help review, thanks.
| "address": "0x35", | ||
| "kernelDeviceName": "w800_scmcpld", | ||
| "pmUnitScopedName": "SCM_CPLD", | ||
| "initRegSettings": [ |
There was a problem hiding this comment.
Please add a __comment__ on why this i2cset is needed for this device.
There was a problem hiding this comment.
I’ve added the requested comment. Please help review, thanks.
| "address": "0x37", | ||
| "kernelDeviceName": "adc128d818", | ||
| "pmUnitScopedName": "SCM_VOLTAGE_MONITOR1", | ||
| "initRegSettings": [ |
There was a problem hiding this comment.
The requested comment has been added here as well.
| "address": "0x1f", | ||
| "kernelDeviceName": "adc128d818", | ||
| "pmUnitScopedName": "SMB_VOLTAGE_MONITOR1", | ||
| "initRegSettings": [ |
There was a problem hiding this comment.
The requested comment has been added here as well.
| "address": "0x35", | ||
| "kernelDeviceName": "adc128d818", | ||
| "pmUnitScopedName": "SMB_VOLTAGE_MONITOR2", | ||
| "initRegSettings": [ |
There was a problem hiding this comment.
The requested comment has been added here as well.
|
Can you also please fix wedge800bact config with the above changes. |
Yes, I will update the wedge800bact configuration accordingly and submit a PR with the changes. |
843db50 to
d17ff20
Compare
|
@brandonchuang has updated the pull request. You must reimport the pull request before landing. |
| "chassisEepromDevicePath": "/[CHASSIS_EEPROM]", | ||
| "numXcvrs": 33, | ||
| "bspKmodsRpmName": "fboss_bsp_kmods", | ||
| "bspKmodsRpmVersion": "3.4.0-1", |
There was a problem hiding this comment.
@brandonchuang , let's bump BSP version to 4.0.0-1, like what we did for wedge800b. Thanks.
There was a problem hiding this comment.
@brandonchuang , let's bump BSP version to 4.0.0-1, like what we did for wedge800b. Thanks.
@tao-ren @RomanChoporov-Meta
Done. The BSP version has been bumped to 4.0.0-1.
| "chassisEepromDevicePath": "/[CHASSIS_EEPROM]", | ||
| "numXcvrs": 33, | ||
| "bspKmodsRpmName": "fboss_bsp_kmods", | ||
| "bspKmodsRpmVersion": "3.4.0-1", |
|
Waiting for a decision regarding pmUnitName in #696 (comment) |
d17ff20 to
031cdd0
Compare
|
@brandonchuang has updated the pull request. You must reimport the pull request before landing. |
@RomanChoporov-Meta |
Summary: Add the initial platform_manager.json configuration for the Wedge800CACT platform manager. Description: Included all platform devices in the platform_manager.json configuration for Wedge800CACT. The configuration was validated on actual Wedge800CACT hardware. Test Plan: - Executed platform_manager with the configuration on Wedge800CACT. [w800c_20251125_platform_manager.txt](https://github.com/user-attachments/files/23741725/w800c_20251125_platform_manager.txt) - Reviewed generated logs to validate correct functionality. - Loaded and unloaded platform_manager and related kernel modules 10 times on kernel 6.11.1 [20251111_run_platform_manager_10_times.py_PASSED.txt](https://github.com/user-attachments/files/23468562/20251111_run_platform_manager_10_times.py_PASSED.txt) - Executed platform_manager_hw_test; all items passed [w800c_20251125_platform_manager_hw_test.txt](https://github.com/user-attachments/files/23741726/w800c_20251125_platform_manager_hw_test.txt) - Verified all sysfs attributes under /run/devmap/cplds/{MCB,SCM,SMB,FAN}_CPLD against i2cget bit values [20251111_run_devmap_cplds_sysfs_test.py_PASSED.txt](https://github.com/user-attachments/files/23468556/20251111_run_devmap_cplds_sysfs_test.py_PASSED.txt) [20251111_run_devmap_sensors_fan_cpld_test.py_PASSED.txt](https://github.com/user-attachments/files/23468557/20251111_run_devmap_sensors_fan_cpld_test.py_PASSED.txt) - Triggered the FAN watchdog and confirmed PWM behavior after timeout [20251111_run_devmap_watchdog_test.py_PASSED.txt](https://github.com/user-attachments/files/23468559/20251111_run_devmap_watchdog_test.py_PASSED.txt) - Accessed fan module LEDs via /sys/class/leds/fan1 and confirmed correctness via i2cget [20251111_led_fan_module_led_test.py_PASSED.txt](https://github.com/user-attachments/files/23468550/20251111_led_fan_module_led_test.py_PASSED.txt) - Accessed front panel LEDs via sysfs and confirmed correctness via i2cget [20251111_led_sys_led_test.py_PASSED.txt](https://github.com/user-attachments/files/23468552/20251111_led_sys_led_test.py_PASSED.txt) - Read/write front port LEDs via sysfs and verified expected output. Compared front port LED values with raw devmem reads. Sequentially programmed port LEDs and verified ordering and color correctness. [20251111_port_led_test.py_PASSED.txt](https://github.com/user-attachments/files/23468555/20251111_port_led_test.py_PASSED.txt) - Verified that all sensors are detected [20251111_run_devmap_sensors_test_strict_version.py_PASSED.txt](https://github.com/user-attachments/files/23468558/20251111_run_devmap_sensors_test_strict_version.py_PASSED.txt) - Read xcvr_ctl via sysfs and compared against raw devmem values [20251111_run_devmap_xcvr_ctrl_sysfs_get_test.py_PASSED.txt](https://github.com/user-attachments/files/23468561/20251111_run_devmap_xcvr_ctrl_sysfs_get_test.py_PASSED.txt) - Triggered the xcvr_reset attribute and verified EEPROM presence/absence behavior. [20251111_run_devmap_xcvr_ctrl_reset_test.py_PASSED.txt](https://github.com/user-attachments/files/23468560/20251111_run_devmap_xcvr_ctrl_reset_test.py_PASSED.txt)
031cdd0 to
2bcb903
Compare
|
@brandonchuang has updated the pull request. You must reimport the pull request before landing. |
|
@RomanChoporov-Meta merged this pull request in c6be5b0. |
Summary:
Add the initial platform_manager.json configuration for the Wedge800CACT platform manager.
Description:
Included all platform devices in the platform_manager.json configuration for Wedge800CACT. The configuration was validated on actual Wedge800CACT hardware.
Test Plan:
w800c_20251125_platform_manager.txt
w800c_20251125_platform_manager_hw_test.txt
20251111_run_devmap_sensors_fan_cpld_test.py_PASSED.txt
20251111_run_devmap_watchdog_test.py_PASSED.txt
20251111_led_sys_led_test.py_PASSED.txt
20251111_port_led_test.py_PASSED.txt
20251111_run_devmap_sensors_test_strict_version.py_PASSED.txt