Skip to content

Add th6 getMaxAclEntries value in AclScaleTestUtils.h#717

Open
cel-gl wants to merge 1 commit into
facebook:mainfrom
cel-gl:fix_AgentNSFScaleTest_th6
Open

Add th6 getMaxAclEntries value in AclScaleTestUtils.h#717
cel-gl wants to merge 1 commit into
facebook:mainfrom
cel-gl:fix_AgentNSFScaleTest_th6

Conversation

@cel-gl

@cel-gl cel-gl commented Dec 3, 2025

Copy link
Copy Markdown
Contributor

Pre-submission checklist
[heshiw@AZUHPS26 fboss]$ git commit -m "Add th6 getMaxAclEntries value in AclScaleTestUtils.h"
clang-format.............................................................Passed
trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check yaml...........................................(no files to check)Skipped
check json...........................................(no files to check)Skipped
check for merge conflicts................................................Passed

Summary

AgentNSFScaleTest.Test test fail on icetea and other th6 platforms, root cause getMaxAclEntries doesn't support th6 , after modify as below show, and add acl group related configs in agent, the case passed

Test Plan

config change : "enable_acl_table_group": "true",

add
"aclTableGroup": {
"name": "acl-table-group-ingress",
"aclTables": [
{
"name": "AclTable1",
"priority": 0,
"aclEntries": [

  ],
  "actionTypes": [
    
  ],
  "qualifiers": [
    
  ],
  "udfGroups": [
    
  ]
}

],
"stage": 0
},
"aclTableGroups": [
{
"name": "acl-table-group-ingress",
"aclTables": [
{
"name": "AclTable1",
"priority": 0,
"aclEntries": [

    ],
    "actionTypes": [
      
    ],
    "qualifiers": [
      
    ],
    "udfGroups": [
      
    ]
  }
],
"stage": 0

}
],

tested on icetea passed

@meta-cla meta-cla Bot added the CLA Signed label Dec 3, 2025
@cel-gl

cel-gl commented Dec 9, 2025

Copy link
Copy Markdown
Contributor Author
@meta-codesync

meta-codesync Bot commented Jan 23, 2026

Copy link
Copy Markdown
Contributor

@mikechoifb has imported this pull request. If you are a Meta employee, you can view this in D91279027.

@cel-gl

cel-gl commented Feb 26, 2026

Copy link
Copy Markdown
Contributor Author

hi @mikechoifb , Can it be merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

1 participant