Add th6 getMaxAclEntries value in AclScaleTestUtils.h#717
Open
cel-gl wants to merge 1 commit into
Open
Conversation
Contributor
Author
Contributor
|
@mikechoifb has imported this pull request. If you are a Meta employee, you can view this in D91279027. |
Contributor
Author
|
hi @mikechoifb , Can it be merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-submission checklist
[heshiw@AZUHPS26 fboss]$ git commit -m "Add th6 getMaxAclEntries value in AclScaleTestUtils.h"
clang-format.............................................................Passed
trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check yaml...........................................(no files to check)Skipped
check json...........................................(no files to check)Skipped
check for merge conflicts................................................Passed
Summary
AgentNSFScaleTest.Test test fail on icetea and other th6 platforms, root cause getMaxAclEntries doesn't support th6 , after modify as below show, and add acl group related configs in agent, the case passed
Test Plan
config change : "enable_acl_table_group": "true",
add
"aclTableGroup": {
"name": "acl-table-group-ingress",
"aclTables": [
{
"name": "AclTable1",
"priority": 0,
"aclEntries": [
],
"stage": 0
},
"aclTableGroups": [
{
"name": "acl-table-group-ingress",
"aclTables": [
{
"name": "AclTable1",
"priority": 0,
"aclEntries": [
}
],
tested on icetea passed