Update/add SCM sensors and thresholds#720
Open
pawagh1 wants to merge 5 commits into
Open
Conversation
- Update temperature sensor thresholds (SCM_OUTLET, SCM_INLET, SCM_CPU_CORE_TEMP_0, SCM_SSD) - Add maxAlarmVal and minAlarmVal thresholds to all voltage sensors - Update threshold values for better monitoring - Add three new sensors: SCM_Vp1P0_PCIE4, SCM_I_VP1P05_CPU, SCM_I_VP1P8_VCCIN
Contributor
|
@mikechoifb has imported this pull request. If you are a Meta employee, you can view this in D89735468. |
mikechoifb
requested changes
Jan 30, 2026
mikechoifb
left a comment
mikechoifb
left a comment
Contributor
There was a problem hiding this comment.
Sensor name such as SCM_Vp1P0_PCIE4 should not contain lower-case letter. Please use uppercase.
After replacing SCM_Vp1P0_PCIE4 to SCM_VP1P0_PCIE4, now we see that this name is used twice (duplicate) - please rename the relevant entry correctly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This update refreshes the SCM section of sensor_service.json so it matches the latest threshold guidance and exposes the additional telemetry that the platform now reports.
Key highlights of this update:
Threshold Definition Updates:
Additional Sensors:
No other fields (slotPath, sysfsPath, pmUnitName, type) were modified; only the thresholds and the new sensor entries were updated.
Test Plan: