[showtech] Fix printGpio segfault#729
Open
huyc-arista wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
@somasun Can we assume showtech can always be run as root user? Non root showtech output is still usefull just not as complete. I don't want this guard to prevent us getting showtech logs if such scenario exist. |
Contributor
Contributor
I think this should be fine. |
ae90d70 to
476b42a
Compare
Contributor
|
@huyc-arista has updated the pull request. You must reimport the pull request before landing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-submission checklist
pip install -r requirements-dev.txt && pre-commit installpre-commit runSummary
Fix potential printGpio() segfault.
gpiod_chip_open()fails.Test Plan
Ran
showtech --details gpiowith invalid gpio path and ensure no crash