Adding missing gflags includes and fixing Makefile#175
Closed
ebetica wants to merge 1 commit into
Closed
Conversation
ghost
added
the
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 24, 2022
Summary: X-link: facebookincubator/katran#175 While working in fixing the build a message of folly::format being deprecated continously appeared, so doing the migration to remove the noise. Reviewed By: avasylev Differential Revision: D39898942 fbshipit-source-id: 45a79c7b8b714b720d86de7a94f50a21f415ab8f
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm trying to compile Thrift on GCC 6.1.1 and ran into some bugs. Fixes are in this PR.