build: update cmake_minimum_required to 3.10#641
Closed
mhx wants to merge 1 commit into
Closed
Conversation
Compatibility with versions older than 3.5 has been deprecated since cmake 3.27 and has now been removed with cmake 4.0. Compatibility with versions before 3.10 has been deprecated since cmake 3.31. This changes the requirement to 3.10 to allow this project to still be built with cmake 4.0 without any deprecation warning.
createdbysk
approved these changes
Mar 14, 2025
createdbysk
left a comment
createdbysk
left a comment
There was a problem hiding this comment.
Verified statements in the description against https://cmake.org/cmake/help/latest/command/cmake_minimum_required.html.
@mhx Thank you for your contribution and support.
Contributor
|
@createdbysk has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
|
@createdbysk merged this pull request in 89808e8. |
facebook-github-bot
pushed a commit
to facebook/hhvm
that referenced
this pull request
Mar 18, 2025
Summary: Compatibility with versions older than 3.5 has been deprecated since cmake 3.27 and has now been removed with cmake 4.0. Compatibility with versions before 3.10 has been deprecated since cmake 3.31. This changes the requirement to 3.10 to allow this project to still be built with cmake 4.0 without any deprecation warning. X-link: facebook/fbthrift#641 Reviewed By: vitaut Differential Revision: D71233832 Pulled By: createdbysk fbshipit-source-id: 7de583b187ac561d4f24b30aacd268400de581fb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compatibility with versions older than 3.5 has been deprecated since cmake 3.27 and has now been removed with cmake 4.0. Compatibility with versions before 3.10 has been deprecated since cmake 3.31.
This changes the requirement to 3.10 to allow this project to still be built with cmake 4.0 without any deprecation warning.