[clang-tidy] Simplify boolean expressions#1301
Closed
neheb wants to merge 1 commit into
Closed
Conversation
Orvid
suggested changes
Jan 6, 2020
Found with readability-simplify-boolean-expr Signed-off-by: Rosen Penev <rosenp@gmail.com>
facebook-github-bot
left a comment
facebook-github-bot
left a comment
Contributor
There was a problem hiding this comment.
@Orvid has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
dotconnor
pushed a commit
to 5448C8/folly
that referenced
this pull request
Mar 19, 2021
Summary: Found with readability-simplify-boolean-expr Signed-off-by: Rosen Penev <rosenp@gmail.com> Pull Request resolved: facebook#1301 Reviewed By: yfeldblum Differential Revision: D19302630 Pulled By: Orvid fbshipit-source-id: 9833e4ab3fe93592fa8f868f6ed2d56a263949fe
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found with readability-simplify-boolean-expr
Signed-off-by: Rosen Penev rosenp@gmail.com