Remove semicolons at the end of macros after do {} while (0)#1605
Closed
JTJL wants to merge 2 commits into
Closed
Conversation
Contributor
|
@yfeldblum has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
yfeldblum
requested changes
Jun 14, 2021
yfeldblum
left a comment
yfeldblum
left a comment
Contributor
There was a problem hiding this comment.
Seems ; is required somewhere - check out the build failures.
Contributor
Author
|
|
Contributor
|
@yfeldblum has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Contributor
|
@yfeldblum merged this pull request in 16ac56e. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The semicolons at the end of macros after
do {} while (0)is useless and may cause potential compile errors in the future.