Fix UninitializedMemoryHacks.h check for asan wtih libc++#2404
Open
pps83 wants to merge 1 commit into
Open
Conversation
Checks were updated from _LIBCPP_HAS_NO_ASAN to _LIBCPP_HAS_ASAN Relevant change: llvm/llvm-project#89178
pps83
referenced
this pull request
Oct 22, 2025
Summary: TSIA. but for more context about the actual build error, see task Reviewed By: Orvid Differential Revision: D77095194 fbshipit-source-id: 441f50876b7d64664116deca25b6ebe9b1936b8e
mszabo-wikia
added a commit
to mszabo-wikia/hhvm
that referenced
this pull request
Jan 23, 2026
libcxx removed all of the macro in favor simple feature test. See: llvm/llvm-project@040e9e0i Ported from facebook/folly#2404
mszabo-wikia
added a commit
to mszabo-wikia/hhvm
that referenced
this pull request
Jan 23, 2026
libcxx removed all of the macro in favor simple feature test. See: llvm/llvm-project@040e9e0i Ported from facebook/folly#2404
mszabo-wikia
added a commit
to mszabo-wikia/hhvm
that referenced
this pull request
Jan 23, 2026
libcxx removed all of the macro in favor simple feature test. See: llvm/llvm-project@040e9e0i Ported from facebook/folly#2404
mszabo-wikia
added a commit
to mszabo-wikia/hhvm
that referenced
this pull request
Mar 14, 2026
libcxx removed all of the macro in favor simple feature test. See: llvm/llvm-project@040e9e0i Ported from facebook/folly#2404
mszabo-wikia
added a commit
to mszabo-wikia/hhvm
that referenced
this pull request
Mar 28, 2026
libcxx removed all of the macro in favor simple feature test. See: llvm/llvm-project@040e9e0i Ported from facebook/folly#2404
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checks were updated from
_LIBCPP_HAS_NO_ASANto_LIBCPP_HAS_ASAN.Relevant change: llvm/llvm-project#89178