fix(oss): explicitly enable coroutine support on g++#2503
Closed
ben-- wants to merge 1 commit into
Closed
Conversation
Contributor
|
o/ I dug up the conversation where I landed this change in fbthrift (facebook/fbthrift#615) and it seems this flag might not be needed on GCC >=11 if c++20 is required (which is now the folly default). Sapling still seems to default to c++17, I wonder if that may be the issue? |
Contributor
Author
|
@mszabo-wikia is correct -- this change is not required if building with However, if this change is dropped, someone may want to update README.md which currently reads:
I'm not arguing one way or another here, but folly needs to decide what its backwards-compatibility strategy ought to be. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
g++ doesn't enable coroutines by default and some upcoming changes require them. This change adds the necessary compiler flag on the open source build. The code here is brought over from fbthrift:
https://github.com/facebook/fbthrift/blob/main/CMakeLists.txt#L71-L75
Tested by including folly in a sapling build with PYTHON_EXTENSIONS enabled.