OSS buck build #2541
Open
OSS buck build #2541
+1,209
−575
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This diff is left in draft because it requires changes in buck2-shims-meta, buck2, and buck2-prelude. PR #2542 includes pins to branches of those projects that include the necessary changes and should demonstrate the build running green. Developers can also pull the branch on my fork: https://github.com/ben--/folly/tree/oss-buck-demo |
ben--
force-pushed
the
oss-buck-build
branch
3 times, most recently
from
f6355bc to
c73efec
Compare
This was referenced Jan 7, 2026
Contributor
Author
|
This PR only works after the following have been merged and pinned: |
While the fbsource//xplat path is probably more correct, the fbcode path should be accessible from fbcode, xplat, and OSS.
Use Promise/Future to control completion instead of futures::sleep, eliminating wall-clock timing dependencies that cause flaky failures on loaded CI systems.
Remove timing assertions (T_CHECK_TIMEOUT) that cause flakiness on Windows due to coarse timer resolution (~15.6ms). The test now verifies only the cancellation logic: which callbacks fired and which were cancelled. Timeout values increased to 50/100/200ms to be well above Windows timer resolution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This stack gets the buck built and GitHub action working in OSS.