Add support for private external_deps in generated CMake#2564
Closed
afrind wants to merge 2 commits into
Closed
Conversation
Summary: Replace usage of boost::thread::barrier with folly::test::Barrier in test files. This reduces the dependency on boost_thread in folly's test code. The folly::test::Barrier is a simple barrier implementation suitable for testing purposes. Differential Revision: D91102520
Summary: Update generate_cmake.py to extract and handle private external_deps from BUCK files, not just exported_external_deps. Previously, only exported_external_deps were converted to CMake EXTERNAL_DEPS. This change adds support for the private external_deps field, ensuring that dependencies like glog are properly linked even when they're private. Differential Revision: D91102521
|
This pull request has been merged in 2eeac0c. |
meta-codesync Bot
pushed a commit
to facebook/hhvm
that referenced
this pull request
Jan 23, 2026
Summary: X-link: facebook/folly#2564 Update generate_cmake.py to extract and handle private external_deps from BUCK files, not just exported_external_deps. Previously, only exported_external_deps were converted to CMake EXTERNAL_DEPS. This change adds support for the private external_deps field, ensuring that dependencies like glog are properly linked even when they're private. Reviewed By: mjoras, yfeldblum Differential Revision: D91102521 fbshipit-source-id: 1b5a1cbb2e36785c13e0ac42214f4fb290bd52dc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Update generate_cmake.py to extract and handle private external_deps from
BUCK files, not just exported_external_deps.
Previously, only exported_external_deps were converted to CMake EXTERNAL_DEPS.
This change adds support for the private external_deps field, ensuring that
dependencies like glog are properly linked even when they're private.
Differential Revision: D91102521