Fix MPMC tests on mac#2573
Closed
afrind wants to merge 1 commit into
Closed
Conversation
Summary: The build is failing due to a static assertion in MPMCQueue.h. The error is that std::string is not nothrow constructible from a const char* (string literal), but the code requires nothrow construction. Differential Revision: D92213016
meta-codesync Bot
pushed a commit
to facebook/hhvm
that referenced
this pull request
Feb 4, 2026
Summary: X-link: facebook/folly#2573 The build is failing due to a static assertion in MPMCQueue.h. The error is that std::string is not nothrow constructible from a const char* (string literal), but the code requires nothrow construction. Reviewed By: kvtsoy Differential Revision: D92213016 fbshipit-source-id: 58e062e285f9ef15a663b3aac23b242dee9a50fe
|
This pull request has been merged in 908fab2. |
bolunfeng
pushed a commit
to bolunfeng/folly
that referenced
this pull request
May 22, 2026
Summary: Pull Request resolved: facebook#2573 The build is failing due to a static assertion in MPMCQueue.h. The error is that std::string is not nothrow constructible from a const char* (string literal), but the code requires nothrow construction. Reviewed By: kvtsoy Differential Revision: D92213016 fbshipit-source-id: 58e062e285f9ef15a663b3aac23b242dee9a50fe
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The build is failing due to a static assertion in MPMCQueue.h. The error is
that std::string is not nothrow constructible from a const char* (string
literal), but the code requires nothrow construction.
Differential Revision: D92213016