Fix libunwind cmake to include lzma in static builds#2586
Closed
afrind wants to merge 1 commit into
Closed
Conversation
Summary: The existing FindLibUnwind.cmake uses a bare find_library which misses transitive dependencies (e.g. lzma, zlib) that static libunwind needs. Switch to preferring pkg-config which picks up the full set of static dependencies from Libs.private, with a fallback to the original find_library approach for systems without pkg-config. Reviewed By: bigfootjon Differential Revision: D93644458
bigfootjon
approved these changes
Feb 20, 2026
bigfootjon
left a comment
bigfootjon
left a comment
Contributor
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
afrind
added a commit
to afrind/folly
that referenced
this pull request
Feb 20, 2026
Summary: The existing FindLibUnwind.cmake uses a bare find_library which misses transitive dependencies (e.g. lzma, zlib) that static libunwind needs. Switch to preferring pkg-config which picks up the full set of static dependencies from Libs.private, with a fallback to the original find_library approach for systems without pkg-config. Reviewed By: bigfootjon Differential Revision: D93644458
|
This pull request has been merged in 0c8d5a0. |
meta-codesync Bot
pushed a commit
to facebook/fb303
that referenced
this pull request
Feb 20, 2026
Summary: X-link: facebook/folly#2586 The existing FindLibUnwind.cmake uses a bare find_library which misses transitive dependencies (e.g. lzma, zlib) that static libunwind needs. Switch to preferring pkg-config which picks up the full set of static dependencies from Libs.private, with a fallback to the original find_library approach for systems without pkg-config. Reviewed By: bigfootjon Differential Revision: D93644458 fbshipit-source-id: b470df008b95497a8db3149c3ddc7b0827c1dee5
meta-codesync Bot
pushed a commit
to facebook/watchman
that referenced
this pull request
Feb 20, 2026
Summary: X-link: facebook/folly#2586 The existing FindLibUnwind.cmake uses a bare find_library which misses transitive dependencies (e.g. lzma, zlib) that static libunwind needs. Switch to preferring pkg-config which picks up the full set of static dependencies from Libs.private, with a fallback to the original find_library approach for systems without pkg-config. Reviewed By: bigfootjon Differential Revision: D93644458 fbshipit-source-id: b470df008b95497a8db3149c3ddc7b0827c1dee5
meta-codesync Bot
pushed a commit
to facebook/openr
that referenced
this pull request
Feb 20, 2026
Summary: X-link: facebook/folly#2586 The existing FindLibUnwind.cmake uses a bare find_library which misses transitive dependencies (e.g. lzma, zlib) that static libunwind needs. Switch to preferring pkg-config which picks up the full set of static dependencies from Libs.private, with a fallback to the original find_library approach for systems without pkg-config. Reviewed By: bigfootjon Differential Revision: D93644458 fbshipit-source-id: b470df008b95497a8db3149c3ddc7b0827c1dee5
meta-codesync Bot
pushed a commit
to facebook/CacheLib
that referenced
this pull request
Feb 20, 2026
Summary: X-link: facebook/folly#2586 The existing FindLibUnwind.cmake uses a bare find_library which misses transitive dependencies (e.g. lzma, zlib) that static libunwind needs. Switch to preferring pkg-config which picks up the full set of static dependencies from Libs.private, with a fallback to the original find_library approach for systems without pkg-config. Reviewed By: bigfootjon Differential Revision: D93644458 fbshipit-source-id: b470df008b95497a8db3149c3ddc7b0827c1dee5
meta-codesync Bot
pushed a commit
to facebook/fboss
that referenced
this pull request
Feb 20, 2026
Summary: X-link: facebook/folly#2586 The existing FindLibUnwind.cmake uses a bare find_library which misses transitive dependencies (e.g. lzma, zlib) that static libunwind needs. Switch to preferring pkg-config which picks up the full set of static dependencies from Libs.private, with a fallback to the original find_library approach for systems without pkg-config. Reviewed By: bigfootjon Differential Revision: D93644458 fbshipit-source-id: b470df008b95497a8db3149c3ddc7b0827c1dee5
meta-codesync Bot
pushed a commit
to facebookexperimental/rust-shed
that referenced
this pull request
Feb 20, 2026
Summary: X-link: facebook/folly#2586 The existing FindLibUnwind.cmake uses a bare find_library which misses transitive dependencies (e.g. lzma, zlib) that static libunwind needs. Switch to preferring pkg-config which picks up the full set of static dependencies from Libs.private, with a fallback to the original find_library approach for systems without pkg-config. Reviewed By: bigfootjon Differential Revision: D93644458 fbshipit-source-id: b470df008b95497a8db3149c3ddc7b0827c1dee5
meta-codesync Bot
pushed a commit
to facebook/wangle
that referenced
this pull request
Feb 20, 2026
Summary: X-link: facebook/folly#2586 The existing FindLibUnwind.cmake uses a bare find_library which misses transitive dependencies (e.g. lzma, zlib) that static libunwind needs. Switch to preferring pkg-config which picks up the full set of static dependencies from Libs.private, with a fallback to the original find_library approach for systems without pkg-config. Reviewed By: bigfootjon Differential Revision: D93644458 fbshipit-source-id: b470df008b95497a8db3149c3ddc7b0827c1dee5
meta-codesync Bot
pushed a commit
to facebook/fbthrift
that referenced
this pull request
Feb 20, 2026
Summary: X-link: facebook/folly#2586 The existing FindLibUnwind.cmake uses a bare find_library which misses transitive dependencies (e.g. lzma, zlib) that static libunwind needs. Switch to preferring pkg-config which picks up the full set of static dependencies from Libs.private, with a fallback to the original find_library approach for systems without pkg-config. Reviewed By: bigfootjon Differential Revision: D93644458 fbshipit-source-id: b470df008b95497a8db3149c3ddc7b0827c1dee5
meta-codesync Bot
pushed a commit
to facebook/mvfst
that referenced
this pull request
Feb 20, 2026
Summary: X-link: facebook/folly#2586 The existing FindLibUnwind.cmake uses a bare find_library which misses transitive dependencies (e.g. lzma, zlib) that static libunwind needs. Switch to preferring pkg-config which picks up the full set of static dependencies from Libs.private, with a fallback to the original find_library approach for systems without pkg-config. Reviewed By: bigfootjon Differential Revision: D93644458 fbshipit-source-id: b470df008b95497a8db3149c3ddc7b0827c1dee5
meta-codesync Bot
pushed a commit
to facebookexperimental/edencommon
that referenced
this pull request
Feb 20, 2026
Summary: X-link: facebook/folly#2586 The existing FindLibUnwind.cmake uses a bare find_library which misses transitive dependencies (e.g. lzma, zlib) that static libunwind needs. Switch to preferring pkg-config which picks up the full set of static dependencies from Libs.private, with a fallback to the original find_library approach for systems without pkg-config. Reviewed By: bigfootjon Differential Revision: D93644458 fbshipit-source-id: b470df008b95497a8db3149c3ddc7b0827c1dee5
meta-codesync Bot
pushed a commit
to facebook/proxygen
that referenced
this pull request
Feb 20, 2026
Summary: X-link: facebook/folly#2586 The existing FindLibUnwind.cmake uses a bare find_library which misses transitive dependencies (e.g. lzma, zlib) that static libunwind needs. Switch to preferring pkg-config which picks up the full set of static dependencies from Libs.private, with a fallback to the original find_library approach for systems without pkg-config. Reviewed By: bigfootjon Differential Revision: D93644458 fbshipit-source-id: b470df008b95497a8db3149c3ddc7b0827c1dee5
meta-codesync Bot
pushed a commit
to facebook/hhvm
that referenced
this pull request
Feb 20, 2026
Summary: X-link: facebook/folly#2586 The existing FindLibUnwind.cmake uses a bare find_library which misses transitive dependencies (e.g. lzma, zlib) that static libunwind needs. Switch to preferring pkg-config which picks up the full set of static dependencies from Libs.private, with a fallback to the original find_library approach for systems without pkg-config. Reviewed By: bigfootjon Differential Revision: D93644458 fbshipit-source-id: b470df008b95497a8db3149c3ddc7b0827c1dee5
meta-codesync Bot
pushed a commit
to facebookincubator/fizz
that referenced
this pull request
Feb 20, 2026
Summary: X-link: facebook/folly#2586 The existing FindLibUnwind.cmake uses a bare find_library which misses transitive dependencies (e.g. lzma, zlib) that static libunwind needs. Switch to preferring pkg-config which picks up the full set of static dependencies from Libs.private, with a fallback to the original find_library approach for systems without pkg-config. Reviewed By: bigfootjon Differential Revision: D93644458 fbshipit-source-id: b470df008b95497a8db3149c3ddc7b0827c1dee5
meta-codesync Bot
pushed a commit
to facebookincubator/katran
that referenced
this pull request
Feb 20, 2026
Summary: X-link: facebook/folly#2586 The existing FindLibUnwind.cmake uses a bare find_library which misses transitive dependencies (e.g. lzma, zlib) that static libunwind needs. Switch to preferring pkg-config which picks up the full set of static dependencies from Libs.private, with a fallback to the original find_library approach for systems without pkg-config. Reviewed By: bigfootjon Differential Revision: D93644458 fbshipit-source-id: b470df008b95497a8db3149c3ddc7b0827c1dee5
meta-codesync Bot
pushed a commit
to facebookexperimental/moxygen
that referenced
this pull request
Feb 20, 2026
Summary: X-link: facebook/folly#2586 The existing FindLibUnwind.cmake uses a bare find_library which misses transitive dependencies (e.g. lzma, zlib) that static libunwind needs. Switch to preferring pkg-config which picks up the full set of static dependencies from Libs.private, with a fallback to the original find_library approach for systems without pkg-config. Reviewed By: bigfootjon Differential Revision: D93644458 fbshipit-source-id: b470df008b95497a8db3149c3ddc7b0827c1dee5
meta-codesync Bot
pushed a commit
to facebookincubator/cinderx
that referenced
this pull request
Feb 20, 2026
Summary: X-link: facebook/folly#2586 The existing FindLibUnwind.cmake uses a bare find_library which misses transitive dependencies (e.g. lzma, zlib) that static libunwind needs. Switch to preferring pkg-config which picks up the full set of static dependencies from Libs.private, with a fallback to the original find_library approach for systems without pkg-config. Reviewed By: bigfootjon Differential Revision: D93644458 fbshipit-source-id: b470df008b95497a8db3149c3ddc7b0827c1dee5
meta-codesync Bot
pushed a commit
to facebookincubator/hsthrift
that referenced
this pull request
Feb 20, 2026
Summary: X-link: facebook/folly#2586 The existing FindLibUnwind.cmake uses a bare find_library which misses transitive dependencies (e.g. lzma, zlib) that static libunwind needs. Switch to preferring pkg-config which picks up the full set of static dependencies from Libs.private, with a fallback to the original find_library approach for systems without pkg-config. Reviewed By: bigfootjon Differential Revision: D93644458 fbshipit-source-id: b470df008b95497a8db3149c3ddc7b0827c1dee5
meta-codesync Bot
pushed a commit
to facebook/sapling
that referenced
this pull request
Feb 20, 2026
Summary: X-link: facebook/folly#2586 The existing FindLibUnwind.cmake uses a bare find_library which misses transitive dependencies (e.g. lzma, zlib) that static libunwind needs. Switch to preferring pkg-config which picks up the full set of static dependencies from Libs.private, with a fallback to the original find_library approach for systems without pkg-config. Reviewed By: bigfootjon Differential Revision: D93644458 fbshipit-source-id: b470df008b95497a8db3149c3ddc7b0827c1dee5
bolunfeng
pushed a commit
to bolunfeng/folly
that referenced
this pull request
May 22, 2026
Summary: Pull Request resolved: facebook#2586 The existing FindLibUnwind.cmake uses a bare find_library which misses transitive dependencies (e.g. lzma, zlib) that static libunwind needs. Switch to preferring pkg-config which picks up the full set of static dependencies from Libs.private, with a fallback to the original find_library approach for systems without pkg-config. Reviewed By: bigfootjon Differential Revision: D93644458 fbshipit-source-id: b470df008b95497a8db3149c3ddc7b0827c1dee5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: The existing FindLibUnwind.cmake uses a bare find_library which misses transitive dependencies (e.g. lzma, zlib) that static libunwind needs. Switch to preferring pkg-config which picks up the full set of static dependencies from Libs.private, with a fallback to the original find_library approach for systems without pkg-config.
Reviewed By: bigfootjon
Differential Revision: D93644458