Static lib handling for glog#2587
Closed
afrind wants to merge 1 commit into
Closed
Conversation
bigfootjon
approved these changes
Feb 20, 2026
bigfootjon
left a comment
bigfootjon
left a comment
Contributor
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
afrind
added a commit
to afrind/folly
that referenced
this pull request
Feb 20, 2026
Summary: Move BUILD_SHARED_LIBS=ON from the unconditional cmake.defines section to a shared_libs=on conditional section in the glog manifest, so that static builds don't force shared library generation. Reviewed By: bigfootjon Differential Revision: D93644456
afrind
force-pushed
the
export-D93644456
branch
2 times, most recently
from
eaa7d5a to
44a06e4
Compare
Summary: Move BUILD_SHARED_LIBS=ON from the unconditional cmake.defines section to a shared_libs=on conditional section in the glog manifest, so that static builds don't force shared library generation. Reviewed By: bigfootjon Differential Revision: D93644456
afrind
force-pushed
the
export-D93644456
branch
from
44a06e4 to
b9e7152
Compare
meta-codesync Bot
pushed a commit
to facebook/fb303
that referenced
this pull request
Feb 21, 2026
Summary: X-link: facebook/folly#2587 Move BUILD_SHARED_LIBS=ON from the unconditional cmake.defines section to a shared_libs=on conditional section in the glog manifest, so that static builds don't force shared library generation. Reviewed By: bigfootjon Differential Revision: D93644456 fbshipit-source-id: b02394c8b370a1a6a730f99fbe6218fd4545e501
meta-codesync Bot
pushed a commit
to facebook/wangle
that referenced
this pull request
Feb 21, 2026
Summary: X-link: facebook/folly#2587 Move BUILD_SHARED_LIBS=ON from the unconditional cmake.defines section to a shared_libs=on conditional section in the glog manifest, so that static builds don't force shared library generation. Reviewed By: bigfootjon Differential Revision: D93644456 fbshipit-source-id: b02394c8b370a1a6a730f99fbe6218fd4545e501
meta-codesync Bot
pushed a commit
to facebook/CacheLib
that referenced
this pull request
Feb 21, 2026
Summary: X-link: facebook/folly#2587 Move BUILD_SHARED_LIBS=ON from the unconditional cmake.defines section to a shared_libs=on conditional section in the glog manifest, so that static builds don't force shared library generation. Reviewed By: bigfootjon Differential Revision: D93644456 fbshipit-source-id: b02394c8b370a1a6a730f99fbe6218fd4545e501
meta-codesync Bot
pushed a commit
to facebookexperimental/edencommon
that referenced
this pull request
Feb 21, 2026
Summary: X-link: facebook/folly#2587 Move BUILD_SHARED_LIBS=ON from the unconditional cmake.defines section to a shared_libs=on conditional section in the glog manifest, so that static builds don't force shared library generation. Reviewed By: bigfootjon Differential Revision: D93644456 fbshipit-source-id: b02394c8b370a1a6a730f99fbe6218fd4545e501
meta-codesync Bot
pushed a commit
to facebook/fboss
that referenced
this pull request
Feb 21, 2026
Summary: X-link: facebook/folly#2587 Move BUILD_SHARED_LIBS=ON from the unconditional cmake.defines section to a shared_libs=on conditional section in the glog manifest, so that static builds don't force shared library generation. Reviewed By: bigfootjon Differential Revision: D93644456 fbshipit-source-id: b02394c8b370a1a6a730f99fbe6218fd4545e501
meta-codesync Bot
pushed a commit
to facebook/mvfst
that referenced
this pull request
Feb 21, 2026
Summary: X-link: facebook/folly#2587 Move BUILD_SHARED_LIBS=ON from the unconditional cmake.defines section to a shared_libs=on conditional section in the glog manifest, so that static builds don't force shared library generation. Reviewed By: bigfootjon Differential Revision: D93644456 fbshipit-source-id: b02394c8b370a1a6a730f99fbe6218fd4545e501
meta-codesync Bot
pushed a commit
to facebook/proxygen
that referenced
this pull request
Feb 21, 2026
Summary: X-link: facebook/folly#2587 Move BUILD_SHARED_LIBS=ON from the unconditional cmake.defines section to a shared_libs=on conditional section in the glog manifest, so that static builds don't force shared library generation. Reviewed By: bigfootjon Differential Revision: D93644456 fbshipit-source-id: b02394c8b370a1a6a730f99fbe6218fd4545e501
meta-codesync Bot
pushed a commit
to facebookincubator/hsthrift
that referenced
this pull request
Feb 21, 2026
Summary: X-link: facebook/folly#2587 Move BUILD_SHARED_LIBS=ON from the unconditional cmake.defines section to a shared_libs=on conditional section in the glog manifest, so that static builds don't force shared library generation. Reviewed By: bigfootjon Differential Revision: D93644456 fbshipit-source-id: b02394c8b370a1a6a730f99fbe6218fd4545e501
meta-codesync Bot
pushed a commit
to facebook/hhvm
that referenced
this pull request
Feb 21, 2026
Summary: X-link: facebook/folly#2587 Move BUILD_SHARED_LIBS=ON from the unconditional cmake.defines section to a shared_libs=on conditional section in the glog manifest, so that static builds don't force shared library generation. Reviewed By: bigfootjon Differential Revision: D93644456 fbshipit-source-id: b02394c8b370a1a6a730f99fbe6218fd4545e501
meta-codesync Bot
pushed a commit
to facebookincubator/fizz
that referenced
this pull request
Feb 21, 2026
Summary: X-link: facebook/folly#2587 Move BUILD_SHARED_LIBS=ON from the unconditional cmake.defines section to a shared_libs=on conditional section in the glog manifest, so that static builds don't force shared library generation. Reviewed By: bigfootjon Differential Revision: D93644456 fbshipit-source-id: b02394c8b370a1a6a730f99fbe6218fd4545e501
meta-codesync Bot
pushed a commit
to facebook/fbthrift
that referenced
this pull request
Feb 21, 2026
Summary: X-link: facebook/folly#2587 Move BUILD_SHARED_LIBS=ON from the unconditional cmake.defines section to a shared_libs=on conditional section in the glog manifest, so that static builds don't force shared library generation. Reviewed By: bigfootjon Differential Revision: D93644456 fbshipit-source-id: b02394c8b370a1a6a730f99fbe6218fd4545e501
meta-codesync Bot
pushed a commit
to facebookincubator/cinderx
that referenced
this pull request
Feb 21, 2026
Summary: X-link: facebook/folly#2587 Move BUILD_SHARED_LIBS=ON from the unconditional cmake.defines section to a shared_libs=on conditional section in the glog manifest, so that static builds don't force shared library generation. Reviewed By: bigfootjon Differential Revision: D93644456 fbshipit-source-id: b02394c8b370a1a6a730f99fbe6218fd4545e501
meta-codesync Bot
pushed a commit
to facebookexperimental/rust-shed
that referenced
this pull request
Feb 21, 2026
Summary: X-link: facebook/folly#2587 Move BUILD_SHARED_LIBS=ON from the unconditional cmake.defines section to a shared_libs=on conditional section in the glog manifest, so that static builds don't force shared library generation. Reviewed By: bigfootjon Differential Revision: D93644456 fbshipit-source-id: b02394c8b370a1a6a730f99fbe6218fd4545e501
meta-codesync Bot
pushed a commit
to facebook/watchman
that referenced
this pull request
Feb 21, 2026
Summary: X-link: facebook/folly#2587 Move BUILD_SHARED_LIBS=ON from the unconditional cmake.defines section to a shared_libs=on conditional section in the glog manifest, so that static builds don't force shared library generation. Reviewed By: bigfootjon Differential Revision: D93644456 fbshipit-source-id: b02394c8b370a1a6a730f99fbe6218fd4545e501
|
This pull request has been merged in 9f0ea45. |
meta-codesync Bot
pushed a commit
to facebookincubator/katran
that referenced
this pull request
Feb 21, 2026
Summary: X-link: facebook/folly#2587 Move BUILD_SHARED_LIBS=ON from the unconditional cmake.defines section to a shared_libs=on conditional section in the glog manifest, so that static builds don't force shared library generation. Reviewed By: bigfootjon Differential Revision: D93644456 fbshipit-source-id: b02394c8b370a1a6a730f99fbe6218fd4545e501
meta-codesync Bot
pushed a commit
to facebook/openr
that referenced
this pull request
Feb 21, 2026
Summary: X-link: facebook/folly#2587 Move BUILD_SHARED_LIBS=ON from the unconditional cmake.defines section to a shared_libs=on conditional section in the glog manifest, so that static builds don't force shared library generation. Reviewed By: bigfootjon Differential Revision: D93644456 fbshipit-source-id: b02394c8b370a1a6a730f99fbe6218fd4545e501
meta-codesync Bot
pushed a commit
to facebookexperimental/moxygen
that referenced
this pull request
Feb 21, 2026
Summary: X-link: facebook/folly#2587 Move BUILD_SHARED_LIBS=ON from the unconditional cmake.defines section to a shared_libs=on conditional section in the glog manifest, so that static builds don't force shared library generation. Reviewed By: bigfootjon Differential Revision: D93644456 fbshipit-source-id: b02394c8b370a1a6a730f99fbe6218fd4545e501
meta-codesync Bot
pushed a commit
to facebook/sapling
that referenced
this pull request
Feb 21, 2026
Summary: X-link: facebook/folly#2587 Move BUILD_SHARED_LIBS=ON from the unconditional cmake.defines section to a shared_libs=on conditional section in the glog manifest, so that static builds don't force shared library generation. Reviewed By: bigfootjon Differential Revision: D93644456 fbshipit-source-id: b02394c8b370a1a6a730f99fbe6218fd4545e501
mszabo-wikia
pushed a commit
to mszabo-wikia/watchman
that referenced
this pull request
Mar 12, 2026
Summary: X-link: facebook/folly#2587 Move BUILD_SHARED_LIBS=ON from the unconditional cmake.defines section to a shared_libs=on conditional section in the glog manifest, so that static builds don't force shared library generation. Reviewed By: bigfootjon Differential Revision: D93644456 fbshipit-source-id: b02394c8b370a1a6a730f99fbe6218fd4545e501
bolunfeng
pushed a commit
to bolunfeng/folly
that referenced
this pull request
May 22, 2026
Summary: Pull Request resolved: facebook#2587 Move BUILD_SHARED_LIBS=ON from the unconditional cmake.defines section to a shared_libs=on conditional section in the glog manifest, so that static builds don't force shared library generation. Reviewed By: bigfootjon Differential Revision: D93644456 fbshipit-source-id: b02394c8b370a1a6a730f99fbe6218fd4545e501
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Move BUILD_SHARED_LIBS=ON from the unconditional cmake.defines section to a shared_libs=on conditional section in the glog manifest, so that static builds don't force shared library generation.
Reviewed By: bigfootjon
Differential Revision: D93644456