Fix fmt::format include in AtomicBatchDispatcher.cpp#2663
Closed
afrind wants to merge 2 commits into
Closed
Conversation
fmt::format is declared in <fmt/format.h>, not <fmt/core.h> on newer fmt (11/12). This file does not pull in format.h transitively, so it fails to build against newer fmt (e.g. homebrew on macOS CI). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Newer fmt (11/12) has no formatter for std::byte, so formatting a std::span<std::byte> via fmt/ranges.h is a hard error. Widen each element to an integer for the diagnostic message. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
@afrind has imported this pull request. If you are a Meta employee, you can view this in D109797682. |
meta-codesync Bot
pushed a commit
to facebook/hhvm
that referenced
this pull request
Jun 26, 2026
Summary: fmt::format is declared in <fmt/format.h>, not <fmt/core.h> on newer fmt (11/12). This file does not pull in format.h transitively, so it fails to build against newer fmt (e.g. homebrew on macOS CI). X-link: facebook/folly#2663 Reviewed By: sandarsh Differential Revision: D109797682 Pulled By: afrind fbshipit-source-id: 68422695b8f4709551ce5a4d373eabf623b1322e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fmt::format is declared in <fmt/format.h>, not <fmt/core.h> on newer fmt (11/12). This file does not pull in format.h transitively, so it fails to build against newer fmt (e.g. homebrew on macOS CI).