Fix#2222 Improved bytearray handling#2432
Conversation
|
Hi iadeelzafar! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
@oprisnik Please review. |
oprisnik
left a comment
oprisnik
left a comment
There was a problem hiding this comment.
Awesome, thanks. Looks good
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@oprisnik has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
|
||
| // allocate java byte array | ||
| dest->javaBuffer = env->NewByteArray(kStreamBufferSize); | ||
| if (dest->buffer == NULL) { |
There was a problem hiding this comment.
shouldn't this be dest->javaBuffer? How did you verify your changes?
|
@iadeelzafar has updated the pull request. Re-import the pull request |
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@oprisnik has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
3 participants
Thanks for submitting a PR! Please read these instructions carefully:
masterbranchMotivation (required)
What existing problem does the pull request solve?
It solves #2222
If you have added code that should be tested, add tests.
This code doesn't needs to be tested.
Next Steps
Sign the CLA, if you haven't already.
Small pull requests are much easier to review and more likely to get merged. Make sure the PR does only one thing, otherwise please split it.
Make sure all tests pass on Circle CI. PRs that break tests are unlikely to be merged.
For more info, see the Contributing guide.