Skip to content

file(...) shouldn't return null for a blank file#1216

Closed
jamesbornholt wants to merge 1 commit into
facebook:masterfrom
jamesbornholt:blank-file
Closed

file(...) shouldn't return null for a blank file#1216
jamesbornholt wants to merge 1 commit into
facebook:masterfrom
jamesbornholt:blank-file

Conversation

@jamesbornholt

@jamesbornholt jamesbornholt commented Oct 26, 2013

Copy link
Copy Markdown
Contributor

If file(...) is called on a blank file, HHVM returns null, but Zend returns a 0-length array.

Fixes #1162.
@jamesbornholt
file() shouldn't return null for a blank file.
78ea1de 
Do what Zend does, return an empty array.
@sgolemon sgolemon closed this in cdfd08e Oct 30, 2013
@jamesbornholt jamesbornholt deleted the blank-file branch October 30, 2013 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant

@jamesbornholt