Aarch64 - Disable executable stacks#8304
Open
jim-saxman wants to merge 1 commit into
Open
Conversation
Summary: This patch marks assembly files as having a non-executable stack. It also updates the Aarch64 gold linker's command line to force the stack to be non-execuatable and throw a warning if the stack becomes executable in the future. There are no new unit test case regressions with this patch, and the time to run the unit test suite is reduced.
Contributor
Author
|
Hi @mxw, @swalk-cavium, can you please review? |
Contributor
|
@jim-saxman - LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This patch marks assembly files as having a non-executable stack.
It also updates the Aarch64 gold linker's command line to force
the stack to be non-execuatable and throw a warning if the stack
becomes executable in the future.
There are no new unit test case regressions with this patch, and
the time to run the unit test suite is greatly reduced.