Spelling vixl#9058
Open
jsoref wants to merge 7 commits into
Open
Conversation
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
jsoref
commented
Apr 6, 2022
Comment on lines
-1468
to
+1472
| enum LSEAquireRelease { | ||
| LSEAquireReleaseN = 0x00000000, | ||
| LSEAquireReleaseA = 0x00800000, | ||
| LSEAquireReleaseL = 0x00400000, | ||
| LSEAquireReleaseAL = 0x00C00000 | ||
| enum LSEAcquireRelease { | ||
| LSEAcquireReleaseN = 0x00000000, | ||
| LSEAcquireReleaseA = 0x00800000, | ||
| LSEAcquireReleaseL = 0x00400000, | ||
| LSEAcquireReleaseAL = 0x00C00000 |
Contributor
Author
There was a problem hiding this comment.
The changes here are by far the scariest. I'm happy to drop them if they're a problem.
Contributor
There was a problem hiding this comment.
I think they are copied from https://github.com/armvixl/vixl. Maybe we should not fix typo in this library.
Contributor
Author
There was a problem hiding this comment.
It looks like that library moved here: https://github.com/Linaro/vixl, I've added it to my list.
Contributor
|
Close and reopen to trigger CI |
Contributor
|
@Atry has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a subset of #9005, it should be easier to review/test/clear
Note: while the top level item is
vixl, if a commit overlaps other directories, I'm lazily including the other changes. If they can safely be dropped from a thing and that makes it easier to merge, I'm happy to do so. By including full spanning commits, I reduce the risk of missing a related change (these tend to result in build/test failures which are painful) at the slight increase in merge conflicts for my general series (these are easy enough for me to clean up)