Build HHVM packages both as an impure derivation and an ordinary derivation#9084
Build HHVM packages both as an impure derivation and an ordinary derivation#9084Atry wants to merge 32 commits into
Conversation
|
@Atry has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Atry
changed the title
|
This pull request was exported from Phabricator. Differential Revision: D36203430 |
…vation (facebook#9084) Summary: The impure derivation is built in a Nix sandbox, which ensures the build script did not accidentally reference any non-Nix dependencies. The default package is not an impure derivation so it is cacheable, but it is built without a Nix sandbox because it requires internet access. Pull Request resolved: facebook#9084 Differential Revision: D36203430 Pulled By: Atry fbshipit-source-id: e856d34c5db99f9df06358988002254777d7ea58
Atry
force-pushed
the
build-both-normal-and-impure-derivation
branch
from
e62b3ee to
d51fde9
Compare
…vation (facebook#9084) Summary: The impure derivation is built in a Nix sandbox, which ensures the build script did not accidentally reference any non-Nix dependencies. The default package is not an impure derivation so it is cacheable, but it is built without a Nix sandbox because it requires internet access. Pull Request resolved: facebook#9084 Differential Revision: D36203430 Pulled By: Atry fbshipit-source-id: 0ddc6bceb6cf4d44398563117b1984f64811c859
Atry
force-pushed
the
build-both-normal-and-impure-derivation
branch
from
d51fde9 to
681b094
Compare
|
This pull request was exported from Phabricator. Differential Revision: D36203430 |
…vation (facebook#9084) Summary: The impure derivation is built in a Nix sandbox, which ensures the build script did not accidentally reference any non-Nix dependencies. The default package is not an impure derivation so it is cacheable, but it is built without a Nix sandbox because it requires internet access. Pull Request resolved: facebook#9084 Differential Revision: D36203430 Pulled By: Atry fbshipit-source-id: 0ddc6bceb6cf4d44398563117b1984f64811c859
Atry
force-pushed
the
build-both-normal-and-impure-derivation
branch
from
681b094 to
67a9074
Compare
|
@Atry has updated the pull request. You must reimport the pull request before landing. |
Atry
force-pushed
the
build-both-normal-and-impure-derivation
branch
from
67a9074 to
b34b91f
Compare
|
@Atry has updated the pull request. You must reimport the pull request before landing. |
Atry
force-pushed
the
build-both-normal-and-impure-derivation
branch
from
b34b91f to
2e7e828
Compare
|
@Atry has updated the pull request. You must reimport the pull request before landing. |
|
@Atry has updated the pull request. You must reimport the pull request before landing. |
|
@Atry has updated the pull request. You must reimport the pull request before landing. |
|
@Atry has updated the pull request. You must reimport the pull request before landing. |
|
@Atry has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@Atry has updated the pull request. You must reimport the pull request before landing. |
…th-normal-and-impure-derivation
|
@Atry has updated the pull request. You must reimport the pull request before landing. |
|
@Atry has updated the pull request. You must reimport the pull request before landing. |
…th-normal-and-impure-derivation
|
@Atry has updated the pull request. You must reimport the pull request before landing. |
Running tests in the checkPhase would let the tests be package specific, i.e. the HHVM built packages with gcc and clang could have separate tests
In the next couple of PR, I will create a new HHVM package compiled with clang, which use the shared settings from common.nix.
…th-normal-and-impure-derivation
|
@Atry has updated the pull request. You must reimport the pull request before landing. |
|
@Atry has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@Atry has updated the pull request. You must reimport the pull request before landing. |
|
@Atry has updated the pull request. You must reimport the pull request before landing. |
|
@Atry has updated the pull request. You must reimport the pull request before landing. |
|
@Atry has updated the pull request. You must reimport the pull request before landing. |
|
Hi @Atry! Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours needs attention. You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
2 participants
The impure derivation is built in a Nix sandbox, which ensures the build script did not accidentally reference any non-Nix dependencies.
The default package is not an impure derivation so it is cacheable, but it must be built without a Nix sandbox because it requires internet access.