Skip to content

directory-structure.md: src/hhbc -> src/hackc#9383

Open
SamB wants to merge 1 commit into
facebook:masterfrom
SamB:patch-1
Open

directory-structure.md: src/hhbc -> src/hackc#9383
SamB wants to merge 1 commit into
facebook:masterfrom
SamB:patch-1

Conversation

@SamB

@SamB SamB commented Jul 19, 2023

Copy link
Copy Markdown

The new byte-compiler got renamed in commit:
43f8698 (Rename directory hhbc to hackc), presumably to disabiguate it from the bytecode format.

I'm not sure how to write tests for this file, but it would be nice if it had some.
@SamB
directory-structure.md: src/hhbc -> src/hackc
4920994 
The new byte-compiler got renamed in commit:
43f8698 (Rename directory hhbc to hackc),
presumably to disabiguate it from the bytecode format.
@facebook-github-bot

facebook-github-bot commented Jul 19, 2023

Copy link
Copy Markdown
Contributor

Hi @SamB!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed

2 participants

@SamB @facebook-github-bot