fix -Wshadow issue#9437
Conversation
|
This pull request was exported from Phabricator. Differential Revision: D54112254 |
Summary:
-Wshadow triggered in LLVM-17:
```
fbcode/folly/futures/ThreadWheelTimekeeper.cpp:61:42: error: declaration shadows a structured binding [-Werror,-Wshadow]
61 | eventBase_.runInEventBaseThread([this, cob = std::move(cob), dur] {
| ^
fbcode/folly/futures/ThreadWheelTimekeeper.cpp:47:9: note: previous declaration is here
47 | auto [cob, sf] = WTCallback<HHWheelTimer>::create(&eventBase_);
| ^
```
This seems to only be triggered in llvm-17, llvm-15 doesn't pick it up:
```
$ buck2 build -c cxx.extra_cxxflags=-Wshadow folly/futures:core
...
BUILD SUCCEEDE
```
Differential Revision: D54112254
44fc669 to
88da2bb
Compare
|
This pull request was exported from Phabricator. Differential Revision: D54112254 |
|
Hi @palmje! Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours needs attention. You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
Summary:
-Wshadow triggered in LLVM-17:
This seems to only be triggered in llvm-17, llvm-15 doesn't pick it up:
Differential Revision: D54112254