Skip to content

Provide OCaml env vars for ocamlrep crate #9635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
mszabo-wikia wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Provide OCaml env vars for ocamlrep crate #9635

mszabo-wikia wants to merge 1 commit into from
+3 −1

Conversation

@mszabo-wikia
Copy link
Contributor

@mszabo-wikia mszabo-wikia commented Sep 24, 2025

build.rs in the ocamlrep crate expects a working OPAM env, so provide it in the setup file.
@meta-cla meta-cla bot added the CLA Signed label Sep 24, 2025
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Sep 24, 2025

@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this in D83145448. (Because this pull request was imported automatically, there will not be any future comments.)
@mszabo-wikia mszabo-wikia force-pushed the export-ocaml-env-to-rust branch from 9a6662b to 12f44bd Compare October 6, 2025 10:59
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Oct 6, 2025

@mszabo-wikia has updated the pull request. You must reimport the pull request before landing.
@meta-codesync
Copy link

meta-codesync bot commented Oct 6, 2025

@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this in D83145448. (Because this pull request was imported automatically, there will not be any future comments.)
@mszabo-wikia mszabo-wikia force-pushed the export-ocaml-env-to-rust branch from 12f44bd to 9909d65 Compare October 6, 2025 11:11
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Oct 6, 2025

@mszabo-wikia has updated the pull request. You must reimport the pull request before landing.
@mszabo-wikia mszabo-wikia force-pushed the export-ocaml-env-to-rust branch from 9909d65 to 2096ee9 Compare December 3, 2025 22:29
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Dec 3, 2025

@mszabo-wikia has updated the pull request. You must reimport the pull request before landing.
@mszabo-wikia mszabo-wikia force-pushed the export-ocaml-env-to-rust branch from 2096ee9 to 61a5e56 Compare December 10, 2025 11:23
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Dec 10, 2025

@mszabo-wikia has updated the pull request. You must reimport the pull request before landing.
@Wilfred
Copy link
Contributor

Wilfred commented Jan 5, 2026

LGTM, just needs a rebase.
@mszabo-wikia
Provide OCaml env vars for ocamlrep crate
e092c12 
build.rs in the ocamlrep crate expects a working OPAM env,
so provide it in the setup file.
@mszabo-wikia mszabo-wikia force-pushed the export-ocaml-env-to-rust branch from 61a5e56 to e092c12 Compare January 6, 2026 17:29
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jan 6, 2026

@mszabo-wikia has updated the pull request. You must reimport the pull request before landing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed

3 participants

@mszabo-wikia @facebook-github-bot @Wilfred