Aarch64: teach VASM about shift/extend operands #9669
+718
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
igogo-x86
commented
Nov 14, 2025
igogo-x86
commented
- add VregShiftExtend and new shift opcodes so ARM can encode shifted/extended GPR operands directly
- wire the new operand through printers, visitors, copy-prop, register allocation, and metadata
- tighten the ARM emitter and simplifier: reuse toOperand(), add folding for ALU/test ops, and guard the lea fold against illegal scales
- add VregShiftExtend and new *shift* opcodes so ARM can encode shifted/extended GPR operands directly - wire the new operand through printers, visitors, copy-prop, register allocation, and metadata - tighten the ARM emitter and simplifier: reuse toOperand(), add folding for ALU/test ops, and guard the lea fold against illegal scales
|
@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this in D87067693. (Because this pull request was imported automatically, there will not be any future comments.) |
|
Hi @igogo-x86, we are hitting merge conflict in vasm-simplify-arm.cpp, can you help rebase and resubmit, thank you! |
|
Hey @igogo-x86, gentle reminder on this, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.