properly bind fragment uniform buffer in multi-pass rendering#337
Closed
SajanGhimire1 wants to merge 5 commits into
Closed
properly bind fragment uniform buffer in multi-pass rendering#337SajanGhimire1 wants to merge 5 commits into
SajanGhimire1 wants to merge 5 commits into
Conversation
Previously, the fragment uniform buffer (`fragmentParamBuffer_`) was not correctly bound for non-OpenGL backends, which could result in incorrect rendering or unexpected colors in multi-pass render sessions. - Ensures `fragmentParamBuffer_` is bound in `render()` for Metal and D3D12. - Maintains correct uniform binding for OpenGL backends. - Verified multi-pass rendering output remains consistent across backends. Ref: TQMultiRenderPassSession.cpp
corporateshark
requested changes
Jan 14, 2026
corporateshark
left a comment
corporateshark
left a comment
Contributor
There was a problem hiding this comment.
Please avoid reformatting any existing code. It makes the review and merge process much more involved.
Added a check to ensure fragmentParamBuffer_ is valid before binding in the render pass. This prevents potential crashes while keeping all rendering logic and backend support intact.
corporateshark
requested changes
Jan 14, 2026
corporateshark
left a comment
corporateshark
left a comment
Contributor
There was a problem hiding this comment.
Please address the above-mentioned comments.
Add null check for fragmentParamBuffer when binding in render() to avoid potential issues on non-OpenGL backends.
SajanGhimire1
commented
Jan 14, 2026
SajanGhimire1
left a comment
SajanGhimire1
left a comment
Contributor
Author
There was a problem hiding this comment.
Addressed the requested changes: added explicit check for fragment uniform buffer pointer without reformatting existing code.
corporateshark
requested changes
Jan 14, 2026
| struct VertexPosUv { | ||
| iglu::simdtypes::float3 position; // SIMD 128b aligned | ||
| iglu::simdtypes::float2 uv; // SIMD 128b aligned | ||
| iglu::simdtypes::float2 uv; // SIMD 128b aligned |
Contributor
There was a problem hiding this comment.
No need to change this line.
| {{1.0f, 1.0f, 0.0}, {1.0, 1.0}}, | ||
| {{-1.0f, -1.0, 0.0}, {0.0, 0.0}}, | ||
| {{1.0f, -1.0f, 0.0}, {1.0, 0.0}}, | ||
| {{1.0f, -1.0, 0.0}, {1.0, 0.0}}, |
Contributor
There was a problem hiding this comment.
Please avoid changing this.
|
|
||
| if (backend != igl::BackendType::OpenGL) { | ||
| commands->bindBuffer(0, fragmentParamBuffer.get()); | ||
| if (fragmentParamBuffer) { |
Contributor
There was a problem hiding this comment.
Since calling bindBuffer() with a nullptr buffer is allowed by the API contract, what exact problem is this PR trying to solve?
Removed unnecessary closing brace for conditional block.
Contributor
|
@corporateshark has imported this pull request. If you are a Meta employee, you can view this in D90706470. |
Contributor
|
@corporateshark merged this pull request in bd388a9. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix syntax error in uniform buffer binding
Fixed misplaced brace that prevented uniform buffers from being bound
for Metal/D3D12 backends in multi-pass rendering.
Root Cause: The original code had incorrect brace placement: