igl | opengl | RenderCommandEncoder::bindBuffer() supports storage buffer#387
Closed
vinsentli wants to merge 2 commits into
Closed
igl | opengl | RenderCommandEncoder::bindBuffer() supports storage buffer#387vinsentli wants to merge 2 commits into
vinsentli wants to merge 2 commits into
Conversation
corporateshark
requested changes
May 12, 2026
| uniformAdapter_.setUniformBuffer(buffer, offset, size, index, outResult); | ||
| } | ||
|
|
||
| void RenderCommandAdapter::setBuffer(Buffer* buffer, size_t offset, uint32_t index) { |
Contributor
There was a problem hiding this comment.
This should be named setStorageBuffer() to avoid confusion (similar to setUniformBuffer() above).
corporateshark
approved these changes
May 13, 2026
Contributor
|
@corporateshark has imported this pull request. If you are a Meta employee, you can view this in D104932618. |
Contributor
|
@corporateshark merged this pull request in eb59933. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.