Skip to content

igl | vulkan | Fix ivkCreateDebugUtilsMessenger use IGL_PLATFORM_APPLE, but vkDestroyDebugUtilsMessengerEXT use IGL_PLATFORM_ANDROID.#393

Closed
vinsentli wants to merge 1 commit into
facebook:mainfrom
vinsentli:vkDestroyDebugUtilsMessengerEXT
Closed

igl | vulkan | Fix ivkCreateDebugUtilsMessenger use IGL_PLATFORM_APPLE, but vkDestroyDebugUtilsMessengerEXT use IGL_PLATFORM_ANDROID.#393
vinsentli wants to merge 1 commit into
facebook:mainfrom
vinsentli:vkDestroyDebugUtilsMessengerEXT

Conversation

@vinsentli

Copy link
Copy Markdown
Contributor

No description provided.

…sengerEXT() and ivkCreateDebugUtilsMessenger().
@meta-cla meta-cla Bot added the cla signed label Jun 2, 2026

@corporateshark corporateshark left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

@vinsentli

vinsentli commented Jun 2, 2026

Copy link
Copy Markdown
Contributor Author

#if !IGL_PLATFORM_APPLE

#if !IGL_PLATFORM_APPLE
  if (features_.enabled(VK_EXT_DEBUG_UTILS_EXTENSION_NAME)) {
    VK_ASSERT(ivkCreateDebugUtilsMessenger(
        &vf_, vkInstance_, &vulkanDebugCallback, this, &vkDebugUtilsMessenger_));
  }
#endif // !IGL_PLATFORM_APPLE
#if !IGL_PLATFORM_ANDROID
  if (vf_.vkDestroyDebugUtilsMessengerEXT != nullptr) {
    vf_.vkDestroyDebugUtilsMessengerEXT(vkInstance_, vkDebugUtilsMessenger_, nullptr);
  }
#endif // !IGL_PLATFORM_ANDROID

ivkCreateDebugUtilsMessenger use IGL_PLATFORM_APPLE, but vkDestroyDebugUtilsMessengerEXT use IGL_PLATFORM_ANDROID.

@corporateshark

@vinsentli vinsentli changed the title igl | vulkan | Fix inconsistent macros used in vkDestroyDebugUtilsMessengerEXT() and ivkCreateDebugUtilsMessenger(). Jun 2, 2026
@meta-codesync

meta-codesync Bot commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

@corporateshark has imported this pull request. If you are a Meta employee, you can view this in D107242865.

@meta-codesync

meta-codesync Bot commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

@corporateshark merged this pull request in 35281c7.

@vinsentli vinsentli deleted the vkDestroyDebugUtilsMessengerEXT branch June 15, 2026 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

2 participants