igl | vulkan | fix: Correct format conversion between AHARDWAREBUFFER_FORMAT and igl::TextureFormat for R5G6B5_UNorm#401
Closed
vinsentli wants to merge 1 commit into
Conversation
Contributor
|
@corporateshark has imported this pull request. If you are a Meta employee, you can view this in D108577875. |
Contributor
|
@corporateshark merged this pull request in 0429b2e. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initially, IGL only supported the TextureFormat::B5G6R5_UNorm format, so AHARDWAREBUFFER_FORMAT_R5G6B5_UNORM was mapped to TextureFormat::B5G6R5_UNorm.
Later, I introduced TextureFormat::R5G6B5_UNorm(#358), which introduced a mapping conflict: both TextureFormat::R5G6B5_UNorm and TextureFormat::B5G6R5_UNorm were forwarded to AHARDWAREBUFFER_FORMAT_R5G6B5_UNORM, while the reverse mapping (from AHARDWAREBUFFER_FORMAT_R5G6B5_UNORM back to an IGL texture format) could only resolve to TextureFormat::B5G6R5_UNorm.
To fix this, I’ve standardized the mapping to exclusively pair AHARDWAREBUFFER_FORMAT_R5G6B5_UNORM with TextureFormat::R5G6B5_UNorm.