[lexical-playground]: Draggable block handle gliding effect#8042
Conversation
ivailop7
requested review from
acywatson,
etrepum,
fantactuka,
potatowagon,
takuyakanbr and
zurfyx
as code owners
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
meta-cla
Bot
added
the
CLA Signed
|
Not sure what is causing the deployment failures, could be something transient? Not sure how to trigger another build without another commit |
|
Not sure either, thought we blocked Vercel builds, but I see other PRs are fine. Will wait on the big pnpm PR to go through and then merge these 2. |
Thank you, pnpm PR is landed. We did block Vercel builds for some time, but at this point in time everything is fully functional. |
etrepum
left a comment
etrepum
left a comment
There was a problem hiding this comment.
I'm not quite sure what's going on here, maybe some layout race condition, but the handle now gets stuck in offset positions after a drop (until it's moved to another element)
Screen.Recording.2025-12-23.at.10.47.59.mov
|
Noted, that's weird. Will have a look in the coming days. |
ivailop7
force-pushed
the
glide_handle
branch
from
44eef02 to
d8fb529
Compare
|
Fixed the onDrop issue, it was also happening for the very first row when entering the textarea with the cursor. All good now. Merging. |
| gap: 2px; | ||
| transition: | ||
| transform 140ms ease-in-out, | ||
| opacity 160ms ease-in-out; |
There was a problem hiding this comment.
There's a transition for opacity, but the opacity is never 0. The code that sets the opacity to 0 is removed in LexicalDraggableBlockPlugin.tsx, if I understand correctly. Even in the playground I don't see the animation.
4 participants
Add a gliding effect to the draggable block handle and a fade-in and fade-out when the handle is shown/hidden.
To remove the 'fly-in' effect due to the current design where the handle is positioned by default at -10000,-10000, made a minor change to make the handle not visible vs positioned off screen when the mouse cursor is not in the textarea. I'm not sure why this was approach taken in a first place. I'm not aware of any accessibility or performance benefits to have it off screen vs hidden.
Screen.Recording.2025-12-19.at.21.25.23.mov