[tests] Chore: Update yaml-language-server in lexical-esm-astro-react integration fixture#8163
Merged
Conversation
Override yaml-language-server to >=1.20.0 which dropped its lodash dependency entirely, removing the vulnerable lodash (<= 4.17.22) from the dependency tree.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
PikkaPikkachu
requested review from
acywatson,
ivailop7 and
potatowagon
as code owners
meta-cla
Bot
added
the
CLA Signed
Collaborator
|
It’s not really a vulnerability in any practical sense, this code only runs in CI. Probably a more useful approach would be to update the dependencies to versions where an override isn’t necessary, in case this code ever makes it to the examples folder. |
etrepum
changed the title
etrepum
approved these changes
Feb 23, 2026
Collaborator
|
Confirmed that @astrojs/check hasn't been updated yet so in the meantime this override is reasonable. Very low priority to worry about "vulnerabilities" in integration tests though. |
Contributor
Author
|
thanks @etrepum for merging in! Makes sense to not update vulnerabilities in tests :) will be putting up some more PRs for more critical vulnerabilities this week! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test plan
lodashis completely absent from the updatedpnpm-lock.yamlastro checkruns successfully with the overriddenyaml-language-server@1.20.0pnpm run test-integration)