Skip to content

[lexical-markdown] Chore: Cover bold italic markdown round trip#8541

Merged
etrepum merged 2 commits into
facebook:mainfrom
rohan-patnaik:fix-markdown-bold-italic-roundtrip
May 23, 2026
Merged

[lexical-markdown] Chore: Cover bold italic markdown round trip#8541
etrepum merged 2 commits into
facebook:mainfrom
rohan-patnaik:fix-markdown-bold-italic-roundtrip

Conversation

@rohan-patnaik

@rohan-patnaik rohan-patnaik commented May 22, 2026

Copy link
Copy Markdown
Contributor

Description

This PR adds regression coverage for markdown text that mixes adjacent bold and bold-italic formatting on the same line.

The reported case already round-trips correctly on current main, so this keeps that behavior covered in lexical-markdown and gives the issue a focused test case.

Closes #7974

Test plan

Before

There was no focused regression test for importing and exporting the reported **text*text*** markdown shape.

After

  • pnpm test-unit packages/lexical-markdown/src/__tests__/unit/LexicalMarkdown.test.ts
@vercel

vercel Bot commented May 22, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
lexical Ready Ready Preview, Comment May 22, 2026 4:23pm
lexical-playground Ready Ready Preview, Comment May 22, 2026 4:23pm

Request Review

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 22, 2026
@etrepum

etrepum commented May 22, 2026

Copy link
Copy Markdown
Collaborator

The title and description of this PR doesn't match the pull request template https://raw.githubusercontent.com/facebook/lexical/refs/heads/main/.github/pull_request_template.md

@etrepum etrepum added the extended-tests Run extended e2e tests on a PR label May 22, 2026
@rohan-patnaik rohan-patnaik changed the title test(markdown): cover bold italic round trip May 22, 2026
@rohan-patnaik

Copy link
Copy Markdown
Contributor Author

@etrepum thanks for the note. I updated the title and PR body to match the template sections. Could you please take another look and let me know if this is in the expected format now?

@etrepum etrepum added this pull request to the merge queue May 23, 2026
Merged via the queue into facebook:main with commit f77e306 May 23, 2026
42 checks passed
@etrepum etrepum mentioned this pull request May 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. extended-tests Run extended e2e tests on a PR

2 participants