[lexical-playground] Chore: Remove localhost:1235 validation server code from ActionsPlugin#8639
Merged
Merged
Conversation
The playground ActionsPlugin contained code that POSTed the editor state to a "read only validation server" at http://localhost:1235 (added in facebook#2899). That server is no longer maintained and does not exist in the repo, so the calls were always silently failing. Remove the dead sendEditorState/validateEditorState helpers, the read-only update-listener validation block, and the now-unused HISTORIC_TAG/COLLABORATION_TAG imports. The lock button now simply toggles editability. https://claude.ai/code/session_01SDcfNeZAtXtJ5fx3NxY9jx
etrepum
requested review from
acywatson,
fantactuka,
ivailop7,
potatowagon and
zurfyx
as code owners
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
meta-cla
Bot
added
the
CLA Signed
zurfyx
approved these changes
Jun 4, 2026
potatowagon
reviewed
Jun 14, 2026
potatowagon
left a comment
potatowagon
left a comment
Contributor
There was a problem hiding this comment.
Reviewed by Navi (Tater Thoughts Bobblehead) on behalf of @potatowagon.
LGTM ✅ — Clean removal of dead code.
What this does: Removes the localhost:1235 validation server functionality from ActionsPlugin (sendEditorState, validateEditorState functions + associated update listener logic). This was a local dev tool that talked to a localhost server that doesn't exist in production or in any documented workflow.
What I checked:
- ✅ Logic correctness: The removed code only communicated with localhost:1235 (dead endpoint). The remaining isEditorEmpty logic is preserved correctly.
- ✅ No regressions: The update listener still correctly determines empty/non-empty editor state. The
isEditabledependency was also correctly removed from the useEffect deps array since it's no longer referenced. - ✅ Unused imports cleaned: COLLABORATION_TAG and HISTORIC_TAG correctly removed since they were only used in the deleted validation logic.
- ✅ No www compat concerns — playground-only change, not a library export.
- ✅ CI: All checks green (core-tests, e2e-tests across all platforms, integration-tests all pass).
Safe to land. Pure dead code removal in a playground plugin.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The playground ActionsPlugin contained code that POSTed the editor state to a "read only validation server" at http://localhost:1235 (added in #2899). That server is no longer maintained and does not exist in the repo, so the calls were always silently failing.
Remove the dead sendEditorState/validateEditorState helpers, the read-only update-listener validation block, and the now-unused HISTORIC_TAG/COLLABORATION_TAG imports. The lock button now simply toggles editability.
Test plan
Not needed