LowerBoundPrefixMap: default constructor to make empty map#434
Closed
DenisYaroshevskiy wants to merge 1 commit into
Closed
LowerBoundPrefixMap: default constructor to make empty map#434DenisYaroshevskiy wants to merge 1 commit into
DenisYaroshevskiy wants to merge 1 commit into
Conversation
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D49242615 |
DenisYaroshevskiy
force-pushed
the
export-D49242615
branch
from
a8cfda0 to
398f0b0
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D49242615 |
facebook-github-bot
pushed a commit
to facebook/hhvm
that referenced
this pull request
Sep 13, 2023
Summary: X-link: facebook/mcrouter#434 Previous default constructor was creating a map with broken invariants. This is maybe acceptable but untill proven that it has performance benefits, let's not. Reviewed By: udippant Differential Revision: D49242615 fbshipit-source-id: 197dd5301c9996e31ecd3b757245f2eaefb5780c
Contributor
|
This pull request has been merged in 8f192cc. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Previous default constructor was creating a map with broken invariants.
This is maybe acceptable but untill proven that it has performance benefits, let's not.
Differential Revision: D49242615