Skip to content

Exclude configerator-related test code in OSS build #465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mszabo-wikia wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −0
Open

Exclude configerator-related test code in OSS build #465

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions mcrouter/routes/test/ShadowSettingsTest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,13 @@
#include <folly/Range.h>
#include <folly/json/json.h>

#ifndef MCROUTER_OSS_BUILD
#include "configerator/distribution/api/ScopedConfigeratorFake.h"
#endif
#include "mcrouter/CarbonRouterInstance.h"
#ifndef MCROUTER_OSS_BUILD
#include "mcrouter/facebook/FbConfigApi.h"
#endif
#include "mcrouter/lib/network/gen/MemcacheRouterInfo.h"
#include "mcrouter/routes/ShadowSettings.h"

Expand Down Expand Up @@ -184,6 +188,7 @@ TEST_F(ShadowSettingsTest, shouldRouteByBucket) {
}
}

#ifndef MCROUTER_OSS_BUILD
TEST_F(ShadowSettingsTest, keyFractionRangeRV) {
// configure RuntimeVarsFile
facebook::configerator::ScopedConfigeratorFake configeratorFake;
Expand Down Expand Up @@ -222,3 +227,4 @@ TEST_F(ShadowSettingsTest, keyFractionRangeRV) {
uint32_t expectedKeyFraction = 0.1 * std::numeric_limits<uint32_t>::max();
ASSERT_TRUE(keyFraction == expectedKeyFraction);
}
#endif
Loading