Add timebase instructions for POWER architecture#57
Closed
leitao wants to merge 1 commit into
Closed
Conversation
Two mcrouter functions depend on time base registers, and this patch enables it to get from POWER architecture. For these functions I am using the built-in __builtin_ppc_get_timebase(), which basically read the time base registers using a set of ASM instructions. With this patch, the mcrouter software builds fine on ppc64el architecture.
facebook-github-bot
pushed a commit
that referenced
this pull request
Sep 26, 2022
Summary: Currently this is using 8K on fiber stack if not outlined by compiler. ``` #56 0x000000000bb1a73b in facebook::memcache::mcrouter::McBucketRoute::route<facebook::memcache::McLeaseGetRequest>(facebook::memcache::McLeaseGetRequest const&) const () at buck-out/v2/gen/fbcode/b64d8fdc2f0705da/mcrouter/__mcrouter_core_no_sr__/headers/mcrouter/routes/McBucketRoute.h:92 #57 facebook::memcache::MemcacheRouteHandle<facebook::memcache::mcrouter::McBucketRoute>::route(facebook::memcache::McLeaseGetRequest const&) (this=<optimized out>, request=...) at buck-out/v2/gen/fbcode/b64d8fdc2f0705da/mcrouter/lib/network/gen/__carbon-Memcache-router-headers__/headers/mcrouter/lib/network/gen/MemcacheRouteHandleIf.h:168 #58 facebook::memcache::SelectionRoute<facebook::memcache::MemcacheRouterInfo, facebook::memcache::HashSelector<facebook::memcache::WeightedCh3HashFunc> >::route<facebook::memcache::McLeaseGetRequest>(facebook::memcache::McLeaseGetRequest const&) (this=<optimized out>, req=...) at buck-out/v2/gen/fbcode/b64d8fdc2f0705da/mcrouter/lib/__routing__/headers/mcrouter/lib/routes/SelectionRoute.h:88 #59 facebook::memcache::MemcacheRouteHandle<facebook::memcache::SelectionRoute<facebook::memcache::MemcacheRouterInfo, facebook::memcache::HashSelector<facebook::memcache::WeightedCh3HashFunc> > >::route(facebook::memcache::McLeaseGetRequest const&) (this=<optimized out>, request=..., ###stackUsed=8400) ``` Reviewed By: lenar-f Differential Revision: D39760867 fbshipit-source-id: cc7ba68c1d92235389664ed62aeb6050335961e1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two mcrouter functions depend on time base registers, and this patch
enables it to get from POWER architecture.
For these functions I am using the built-in __builtin_ppc_get_timebase(),
which basically read the time base registers using a set of ASM
instructions.
With this patch, the mcrouter software builds fine on ppc64el architecture.