This repository was archived by the owner on Mar 1, 2026. It is now read-only.
Implement server side changes for XtraBackup MyRocks#1030
Open
george-lorch wants to merge 1 commit into
Open
Conversation
- Requires RocksDB submodule to be up to or past 3f5c1236026233b34be64d597fe660d7e698f2f5 - Isolated all MyRocks 8 code chenges within #ifdef MYROCKS_8. Once this code is unblocked, rocksdb.rocksdb will need to be re-recorded. - Added new session variable to MyRocks rocksdb_create_temporary_checkpoint which will create a temporary RocksDB 'checkpoint' or 'snapshot'. If the session ends with an existing checkpoint, or if the variable is reset to another value, the checkpoint will get removed. - Added new session variable to MyRocks rocksdb_disable_file_deletions, which when set, will tell RocksDB to disable the deletion of old WAL and .sst files. If the session ends without re-enabling file deletion, file deletions will be explicitly re-enabled. - Expose rocksdb WAL position in i_s.log_status table. - Added tests to MyRocks for new options and behaviors.
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@luqun has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
facebook-github-bot
pushed a commit
that referenced
this pull request
Feb 6, 2020
Summary: - Requires RocksDB submodule to be up to or past 3f5c1236026233b34be64d597fe660d7e698f2f5 - Added new session variable to MyRocks rocksdb_create_temporary_checkpoint which will create a temporary RocksDB 'checkpoint' or 'snapshot'. If the session ends with an existing checkpoint, or if the variable is reset to another value, the checkpoint will get removed. - Added new session variable to MyRocks rocksdb_disable_file_deletions, which when set, will tell RocksDB to disable the deletion of old WAL and .sst files. If the session ends without re-enabling file deletion, file deletions will be explicitly re-enabled. - Expose rocksdb WAL position in i_s.log_status table. - Added tests to MyRocks for new options and behaviors. Pull Request resolved: #1030 Reviewed By: yizhang82 Differential Revision: D19487165 Pulled By: luqun fbshipit-source-id: 1d5fb36
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Aug 13, 2020
Summary: - Requires RocksDB submodule to be up to or past 3f5c1236026233b34be64d597fe660d7e698f2f5 - Added new session variable to MyRocks rocksdb_create_temporary_checkpoint which will create a temporary RocksDB 'checkpoint' or 'snapshot'. If the session ends with an existing checkpoint, or if the variable is reset to another value, the checkpoint will get removed. - Added new session variable to MyRocks rocksdb_disable_file_deletions, which when set, will tell RocksDB to disable the deletion of old WAL and .sst files. If the session ends without re-enabling file deletion, file deletions will be explicitly re-enabled. - Expose rocksdb WAL position in i_s.log_status table. - Added tests to MyRocks for new options and behaviors. Pull Request resolved: facebook#1030 Reviewed By: yizhang82 Differential Revision: D19487165 Pulled By: luqun fbshipit-source-id: 1d5fb36
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Sep 9, 2020
Summary: - Requires RocksDB submodule to be up to or past 3f5c1236026233b34be64d597fe660d7e698f2f5 - Added new session variable to MyRocks rocksdb_create_temporary_checkpoint which will create a temporary RocksDB 'checkpoint' or 'snapshot'. If the session ends with an existing checkpoint, or if the variable is reset to another value, the checkpoint will get removed. - Added new session variable to MyRocks rocksdb_disable_file_deletions, which when set, will tell RocksDB to disable the deletion of old WAL and .sst files. If the session ends without re-enabling file deletion, file deletions will be explicitly re-enabled. - Expose rocksdb WAL position in i_s.log_status table. - Added tests to MyRocks for new options and behaviors. Pull Request resolved: facebook#1030 Reviewed By: yizhang82 Differential Revision: D19487165 Pulled By: luqun fbshipit-source-id: 1d5fb36
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Sep 10, 2020
Summary: - Requires RocksDB submodule to be up to or past 3f5c1236026233b34be64d597fe660d7e698f2f5 - Added new session variable to MyRocks rocksdb_create_temporary_checkpoint which will create a temporary RocksDB 'checkpoint' or 'snapshot'. If the session ends with an existing checkpoint, or if the variable is reset to another value, the checkpoint will get removed. - Added new session variable to MyRocks rocksdb_disable_file_deletions, which when set, will tell RocksDB to disable the deletion of old WAL and .sst files. If the session ends without re-enabling file deletion, file deletions will be explicitly re-enabled. - Expose rocksdb WAL position in i_s.log_status table. - Added tests to MyRocks for new options and behaviors. Pull Request resolved: facebook#1030 Reviewed By: yizhang82 Differential Revision: D19487165 Pulled By: luqun fbshipit-source-id: 1d5fb36
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Sep 11, 2020
Summary: - Requires RocksDB submodule to be up to or past 3f5c1236026233b34be64d597fe660d7e698f2f5 - Added new session variable to MyRocks rocksdb_create_temporary_checkpoint which will create a temporary RocksDB 'checkpoint' or 'snapshot'. If the session ends with an existing checkpoint, or if the variable is reset to another value, the checkpoint will get removed. - Added new session variable to MyRocks rocksdb_disable_file_deletions, which when set, will tell RocksDB to disable the deletion of old WAL and .sst files. If the session ends without re-enabling file deletion, file deletions will be explicitly re-enabled. - Expose rocksdb WAL position in i_s.log_status table. - Added tests to MyRocks for new options and behaviors. Pull Request resolved: facebook#1030 Reviewed By: yizhang82 Differential Revision: D19487165 Pulled By: luqun fbshipit-source-id: 1d5fb36
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Sep 16, 2020
Summary: - Requires RocksDB submodule to be up to or past 3f5c1236026233b34be64d597fe660d7e698f2f5 - Added new session variable to MyRocks rocksdb_create_temporary_checkpoint which will create a temporary RocksDB 'checkpoint' or 'snapshot'. If the session ends with an existing checkpoint, or if the variable is reset to another value, the checkpoint will get removed. - Added new session variable to MyRocks rocksdb_disable_file_deletions, which when set, will tell RocksDB to disable the deletion of old WAL and .sst files. If the session ends without re-enabling file deletion, file deletions will be explicitly re-enabled. - Expose rocksdb WAL position in i_s.log_status table. - Added tests to MyRocks for new options and behaviors. Pull Request resolved: facebook#1030 Reviewed By: yizhang82 Differential Revision: D19487165 Pulled By: luqun fbshipit-source-id: 1d5fb36
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Oct 5, 2020
Summary: - Requires RocksDB submodule to be up to or past 3f5c1236026233b34be64d597fe660d7e698f2f5 - Added new session variable to MyRocks rocksdb_create_temporary_checkpoint which will create a temporary RocksDB 'checkpoint' or 'snapshot'. If the session ends with an existing checkpoint, or if the variable is reset to another value, the checkpoint will get removed. - Added new session variable to MyRocks rocksdb_disable_file_deletions, which when set, will tell RocksDB to disable the deletion of old WAL and .sst files. If the session ends without re-enabling file deletion, file deletions will be explicitly re-enabled. - Expose rocksdb WAL position in i_s.log_status table. - Added tests to MyRocks for new options and behaviors. Pull Request resolved: facebook#1030 Reviewed By: yizhang82 Differential Revision: D19487165 Pulled By: luqun fbshipit-source-id: 1d5fb36
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Nov 11, 2020
Summary: - Requires RocksDB submodule to be up to or past 3f5c1236026233b34be64d597fe660d7e698f2f5 - Added new session variable to MyRocks rocksdb_create_temporary_checkpoint which will create a temporary RocksDB 'checkpoint' or 'snapshot'. If the session ends with an existing checkpoint, or if the variable is reset to another value, the checkpoint will get removed. - Added new session variable to MyRocks rocksdb_disable_file_deletions, which when set, will tell RocksDB to disable the deletion of old WAL and .sst files. If the session ends without re-enabling file deletion, file deletions will be explicitly re-enabled. - Expose rocksdb WAL position in i_s.log_status table. - Added tests to MyRocks for new options and behaviors. Pull Request resolved: facebook#1030 Reviewed By: yizhang82 Differential Revision: D19487165 Pulled By: luqun fbshipit-source-id: 1d5fb36
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 8, 2021
Summary: - Requires RocksDB submodule to be up to or past 3f5c1236026233b34be64d597fe660d7e698f2f5 - Added new session variable to MyRocks rocksdb_create_temporary_checkpoint which will create a temporary RocksDB 'checkpoint' or 'snapshot'. If the session ends with an existing checkpoint, or if the variable is reset to another value, the checkpoint will get removed. - Added new session variable to MyRocks rocksdb_disable_file_deletions, which when set, will tell RocksDB to disable the deletion of old WAL and .sst files. If the session ends without re-enabling file deletion, file deletions will be explicitly re-enabled. - Expose rocksdb WAL position in i_s.log_status table. - Added tests to MyRocks for new options and behaviors. Pull Request resolved: #1030 Differential Revision: D19487165 (f44048c) Pulled By: luqun fbshipit-source-id: 863cc8364e3
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Aug 16, 2021
…acebook#1030) Summary: - Requires RocksDB submodule to be up to or past 3f5c1236026233b34be64d597fe660d7e698f2f5 - Added new session variable to MyRocks rocksdb_create_temporary_checkpoint which will create a temporary RocksDB 'checkpoint' or 'snapshot'. If the session ends with an existing checkpoint, or if the variable is reset to another value, the checkpoint will get removed. - Added new session variable to MyRocks rocksdb_disable_file_deletions, which when set, will tell RocksDB to disable the deletion of old WAL and .sst files. If the session ends without re-enabling file deletion, file deletions will be explicitly re-enabled. - Expose rocksdb WAL position in i_s.log_status table. - Added tests to MyRocks for new options and behaviors. Pull Request resolved: facebook#1030 Differential Revision: D19487165 (facebook@f44048c) Pulled By: luqun fbshipit-source-id: 863cc8364e3
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Aug 17, 2021
…acebook#1030) Summary: - Requires RocksDB submodule to be up to or past 3f5c1236026233b34be64d597fe660d7e698f2f5 - Added new session variable to MyRocks rocksdb_create_temporary_checkpoint which will create a temporary RocksDB 'checkpoint' or 'snapshot'. If the session ends with an existing checkpoint, or if the variable is reset to another value, the checkpoint will get removed. - Added new session variable to MyRocks rocksdb_disable_file_deletions, which when set, will tell RocksDB to disable the deletion of old WAL and .sst files. If the session ends without re-enabling file deletion, file deletions will be explicitly re-enabled. - Expose rocksdb WAL position in i_s.log_status table. - Added tests to MyRocks for new options and behaviors. Pull Request resolved: facebook#1030 Differential Revision: D19487165 (facebook@f44048c) Pulled By: luqun fbshipit-source-id: 863cc8364e3
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Aug 30, 2021
…acebook#1030) Summary: - Requires RocksDB submodule to be up to or past 3f5c1236026233b34be64d597fe660d7e698f2f5 - Added new session variable to MyRocks rocksdb_create_temporary_checkpoint which will create a temporary RocksDB 'checkpoint' or 'snapshot'. If the session ends with an existing checkpoint, or if the variable is reset to another value, the checkpoint will get removed. - Added new session variable to MyRocks rocksdb_disable_file_deletions, which when set, will tell RocksDB to disable the deletion of old WAL and .sst files. If the session ends without re-enabling file deletion, file deletions will be explicitly re-enabled. - Expose rocksdb WAL position in i_s.log_status table. - Added tests to MyRocks for new options and behaviors. Pull Request resolved: facebook#1030 Differential Revision: D19487165 (facebook@f44048c) Pulled By: luqun fbshipit-source-id: 863cc8364e3
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Aug 30, 2021
…acebook#1030) Summary: - Requires RocksDB submodule to be up to or past 3f5c1236026233b34be64d597fe660d7e698f2f5 - Added new session variable to MyRocks rocksdb_create_temporary_checkpoint which will create a temporary RocksDB 'checkpoint' or 'snapshot'. If the session ends with an existing checkpoint, or if the variable is reset to another value, the checkpoint will get removed. - Added new session variable to MyRocks rocksdb_disable_file_deletions, which when set, will tell RocksDB to disable the deletion of old WAL and .sst files. If the session ends without re-enabling file deletion, file deletions will be explicitly re-enabled. - Expose rocksdb WAL position in i_s.log_status table. - Added tests to MyRocks for new options and behaviors. Pull Request resolved: facebook#1030 Differential Revision: D19487165 (facebook@f44048c) Pulled By: luqun fbshipit-source-id: 863cc8364e3
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Aug 31, 2021
…acebook#1030) Summary: - Requires RocksDB submodule to be up to or past 3f5c1236026233b34be64d597fe660d7e698f2f5 - Added new session variable to MyRocks rocksdb_create_temporary_checkpoint which will create a temporary RocksDB 'checkpoint' or 'snapshot'. If the session ends with an existing checkpoint, or if the variable is reset to another value, the checkpoint will get removed. - Added new session variable to MyRocks rocksdb_disable_file_deletions, which when set, will tell RocksDB to disable the deletion of old WAL and .sst files. If the session ends without re-enabling file deletion, file deletions will be explicitly re-enabled. - Expose rocksdb WAL position in i_s.log_status table. - Added tests to MyRocks for new options and behaviors. Pull Request resolved: facebook#1030 Differential Revision: D19487165 (facebook@f44048c) Pulled By: luqun fbshipit-source-id: 863cc8364e3
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Aug 31, 2021
…acebook#1030) Summary: - Requires RocksDB submodule to be up to or past 3f5c1236026233b34be64d597fe660d7e698f2f5 - Added new session variable to MyRocks rocksdb_create_temporary_checkpoint which will create a temporary RocksDB 'checkpoint' or 'snapshot'. If the session ends with an existing checkpoint, or if the variable is reset to another value, the checkpoint will get removed. - Added new session variable to MyRocks rocksdb_disable_file_deletions, which when set, will tell RocksDB to disable the deletion of old WAL and .sst files. If the session ends without re-enabling file deletion, file deletions will be explicitly re-enabled. - Expose rocksdb WAL position in i_s.log_status table. - Added tests to MyRocks for new options and behaviors. Pull Request resolved: facebook#1030 Differential Revision: D19487165 (facebook@f44048c) Pulled By: luqun fbshipit-source-id: 863cc8364e3
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Sep 1, 2021
…acebook#1030) Summary: - Requires RocksDB submodule to be up to or past 3f5c1236026233b34be64d597fe660d7e698f2f5 - Added new session variable to MyRocks rocksdb_create_temporary_checkpoint which will create a temporary RocksDB 'checkpoint' or 'snapshot'. If the session ends with an existing checkpoint, or if the variable is reset to another value, the checkpoint will get removed. - Added new session variable to MyRocks rocksdb_disable_file_deletions, which when set, will tell RocksDB to disable the deletion of old WAL and .sst files. If the session ends without re-enabling file deletion, file deletions will be explicitly re-enabled. - Expose rocksdb WAL position in i_s.log_status table. - Added tests to MyRocks for new options and behaviors. Pull Request resolved: facebook#1030 Differential Revision: D19487165 (facebook@f44048c) Pulled By: luqun fbshipit-source-id: 863cc8364e3
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Sep 2, 2021
…acebook#1030) Summary: - Requires RocksDB submodule to be up to or past 3f5c1236026233b34be64d597fe660d7e698f2f5 - Added new session variable to MyRocks rocksdb_create_temporary_checkpoint which will create a temporary RocksDB 'checkpoint' or 'snapshot'. If the session ends with an existing checkpoint, or if the variable is reset to another value, the checkpoint will get removed. - Added new session variable to MyRocks rocksdb_disable_file_deletions, which when set, will tell RocksDB to disable the deletion of old WAL and .sst files. If the session ends without re-enabling file deletion, file deletions will be explicitly re-enabled. - Expose rocksdb WAL position in i_s.log_status table. - Added tests to MyRocks for new options and behaviors. Pull Request resolved: facebook#1030 Differential Revision: D19487165 (facebook@f44048c) Pulled By: luqun fbshipit-source-id: 863cc8364e3
hermanlee
pushed a commit
that referenced
this pull request
Jan 10, 2022
Summary: - Requires RocksDB submodule to be up to or past 3f5c1236026233b34be64d597fe660d7e698f2f5 - Added new session variable to MyRocks rocksdb_create_temporary_checkpoint which will create a temporary RocksDB 'checkpoint' or 'snapshot'. If the session ends with an existing checkpoint, or if the variable is reset to another value, the checkpoint will get removed. - Added new session variable to MyRocks rocksdb_disable_file_deletions, which when set, will tell RocksDB to disable the deletion of old WAL and .sst files. If the session ends without re-enabling file deletion, file deletions will be explicitly re-enabled. - Expose rocksdb WAL position in i_s.log_status table. - Added tests to MyRocks for new options and behaviors. Pull Request resolved: #1030 Differential Revision: D19487165 Pulled By: luqun
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jan 17, 2022
…acebook#1030) Summary: - Requires RocksDB submodule to be up to or past 3f5c1236026233b34be64d597fe660d7e698f2f5 - Added new session variable to MyRocks rocksdb_create_temporary_checkpoint which will create a temporary RocksDB 'checkpoint' or 'snapshot'. If the session ends with an existing checkpoint, or if the variable is reset to another value, the checkpoint will get removed. - Added new session variable to MyRocks rocksdb_disable_file_deletions, which when set, will tell RocksDB to disable the deletion of old WAL and .sst files. If the session ends without re-enabling file deletion, file deletions will be explicitly re-enabled. - Expose rocksdb WAL position in i_s.log_status table. - Added tests to MyRocks for new options and behaviors. Pull Request resolved: facebook#1030 Differential Revision: D19487165 Pulled By: luqun
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jan 17, 2022
…acebook#1030) Summary: - Requires RocksDB submodule to be up to or past 3f5c1236026233b34be64d597fe660d7e698f2f5 - Added new session variable to MyRocks rocksdb_create_temporary_checkpoint which will create a temporary RocksDB 'checkpoint' or 'snapshot'. If the session ends with an existing checkpoint, or if the variable is reset to another value, the checkpoint will get removed. - Added new session variable to MyRocks rocksdb_disable_file_deletions, which when set, will tell RocksDB to disable the deletion of old WAL and .sst files. If the session ends without re-enabling file deletion, file deletions will be explicitly re-enabled. - Expose rocksdb WAL position in i_s.log_status table. - Added tests to MyRocks for new options and behaviors. Pull Request resolved: facebook#1030 Differential Revision: D19487165 Pulled By: luqun
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jan 17, 2022
…acebook#1030) Summary: - Requires RocksDB submodule to be up to or past 3f5c1236026233b34be64d597fe660d7e698f2f5 - Added new session variable to MyRocks rocksdb_create_temporary_checkpoint which will create a temporary RocksDB 'checkpoint' or 'snapshot'. If the session ends with an existing checkpoint, or if the variable is reset to another value, the checkpoint will get removed. - Added new session variable to MyRocks rocksdb_disable_file_deletions, which when set, will tell RocksDB to disable the deletion of old WAL and .sst files. If the session ends without re-enabling file deletion, file deletions will be explicitly re-enabled. - Expose rocksdb WAL position in i_s.log_status table. - Added tests to MyRocks for new options and behaviors. Pull Request resolved: facebook#1030 Differential Revision: D19487165 Pulled By: luqun
ldonoso
pushed a commit
to ldonoso/percona-server
that referenced
this pull request
Mar 15, 2022
…ercona#1030) Summary: - Requires RocksDB submodule to be up to or past 3f5c1236026233b34be64d597fe660d7e698f2f5 - Added new session variable to MyRocks rocksdb_create_temporary_checkpoint which will create a temporary RocksDB 'checkpoint' or 'snapshot'. If the session ends with an existing checkpoint, or if the variable is reset to another value, the checkpoint will get removed. - Added new session variable to MyRocks rocksdb_disable_file_deletions, which when set, will tell RocksDB to disable the deletion of old WAL and .sst files. If the session ends without re-enabling file deletion, file deletions will be explicitly re-enabled. - Expose rocksdb WAL position in i_s.log_status table. - Added tests to MyRocks for new options and behaviors. Pull Request resolved: facebook/mysql-5.6#1030 Differential Revision: D19487165 Pulled By: luqun
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 20, 2022
…acebook#1030) Summary: - Requires RocksDB submodule to be up to or past 3f5c1236026233b34be64d597fe660d7e698f2f5 - Added new session variable to MyRocks rocksdb_create_temporary_checkpoint which will create a temporary RocksDB 'checkpoint' or 'snapshot'. If the session ends with an existing checkpoint, or if the variable is reset to another value, the checkpoint will get removed. - Added new session variable to MyRocks rocksdb_disable_file_deletions, which when set, will tell RocksDB to disable the deletion of old WAL and .sst files. If the session ends without re-enabling file deletion, file deletions will be explicitly re-enabled. - Expose rocksdb WAL position in i_s.log_status table. - Added tests to MyRocks for new options and behaviors. Pull Request resolved: facebook#1030 Differential Revision: D19487165 Pulled By: luqun
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 23, 2022
…acebook#1030) Summary: - Requires RocksDB submodule to be up to or past 3f5c1236026233b34be64d597fe660d7e698f2f5 - Added new session variable to MyRocks rocksdb_create_temporary_checkpoint which will create a temporary RocksDB 'checkpoint' or 'snapshot'. If the session ends with an existing checkpoint, or if the variable is reset to another value, the checkpoint will get removed. - Added new session variable to MyRocks rocksdb_disable_file_deletions, which when set, will tell RocksDB to disable the deletion of old WAL and .sst files. If the session ends without re-enabling file deletion, file deletions will be explicitly re-enabled. - Expose rocksdb WAL position in i_s.log_status table. - Added tests to MyRocks for new options and behaviors. Pull Request resolved: facebook#1030 Differential Revision: D19487165 Pulled By: luqun
hermanlee
pushed a commit
that referenced
this pull request
Aug 2, 2022
Summary: - Requires RocksDB submodule to be up to or past 3f5c1236026233b34be64d597fe660d7e698f2f5 - Added new session variable to MyRocks rocksdb_create_temporary_checkpoint which will create a temporary RocksDB 'checkpoint' or 'snapshot'. If the session ends with an existing checkpoint, or if the variable is reset to another value, the checkpoint will get removed. - Added new session variable to MyRocks rocksdb_disable_file_deletions, which when set, will tell RocksDB to disable the deletion of old WAL and .sst files. If the session ends without re-enabling file deletion, file deletions will be explicitly re-enabled. - Expose rocksdb WAL position in i_s.log_status table. - Added tests to MyRocks for new options and behaviors. Pull Request resolved: #1030 Differential Revision: D19487165 Pulled By: luqun
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Mar 25, 2023
…acebook#1030) Summary: - Requires RocksDB submodule to be up to or past 3f5c1236026233b34be64d597fe660d7e698f2f5 - Added new session variable to MyRocks rocksdb_create_temporary_checkpoint which will create a temporary RocksDB 'checkpoint' or 'snapshot'. If the session ends with an existing checkpoint, or if the variable is reset to another value, the checkpoint will get removed. - Added new session variable to MyRocks rocksdb_disable_file_deletions, which when set, will tell RocksDB to disable the deletion of old WAL and .sst files. If the session ends without re-enabling file deletion, file deletions will be explicitly re-enabled. - Expose rocksdb WAL position in i_s.log_status table. - Added tests to MyRocks for new options and behaviors. Pull Request resolved: facebook#1030 Differential Revision: D19487165 Pulled By: luqun
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Mar 28, 2023
…acebook#1030) Summary: - Requires RocksDB submodule to be up to or past 3f5c1236026233b34be64d597fe660d7e698f2f5 - Added new session variable to MyRocks rocksdb_create_temporary_checkpoint which will create a temporary RocksDB 'checkpoint' or 'snapshot'. If the session ends with an existing checkpoint, or if the variable is reset to another value, the checkpoint will get removed. - Added new session variable to MyRocks rocksdb_disable_file_deletions, which when set, will tell RocksDB to disable the deletion of old WAL and .sst files. If the session ends without re-enabling file deletion, file deletions will be explicitly re-enabled. - Expose rocksdb WAL position in i_s.log_status table. - Added tests to MyRocks for new options and behaviors. Pull Request resolved: facebook#1030 Differential Revision: D19487165 Pulled By: luqun
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Mar 28, 2023
…acebook#1030) Summary: - Requires RocksDB submodule to be up to or past 3f5c1236026233b34be64d597fe660d7e698f2f5 - Added new session variable to MyRocks rocksdb_create_temporary_checkpoint which will create a temporary RocksDB 'checkpoint' or 'snapshot'. If the session ends with an existing checkpoint, or if the variable is reset to another value, the checkpoint will get removed. - Added new session variable to MyRocks rocksdb_disable_file_deletions, which when set, will tell RocksDB to disable the deletion of old WAL and .sst files. If the session ends without re-enabling file deletion, file deletions will be explicitly re-enabled. - Expose rocksdb WAL position in i_s.log_status table. - Added tests to MyRocks for new options and behaviors. Pull Request resolved: facebook#1030 Differential Revision: D19487165 Pulled By: luqun
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jun 1, 2023
…acebook#1030) Summary: - Requires RocksDB submodule to be up to or past 3f5c1236026233b34be64d597fe660d7e698f2f5 - Added new session variable to MyRocks rocksdb_create_temporary_checkpoint which will create a temporary RocksDB 'checkpoint' or 'snapshot'. If the session ends with an existing checkpoint, or if the variable is reset to another value, the checkpoint will get removed. - Added new session variable to MyRocks rocksdb_disable_file_deletions, which when set, will tell RocksDB to disable the deletion of old WAL and .sst files. If the session ends without re-enabling file deletion, file deletions will be explicitly re-enabled. - Expose rocksdb WAL position in i_s.log_status table. - Added tests to MyRocks for new options and behaviors. Pull Request resolved: facebook#1030 Differential Revision: D19487165 Pulled By: luqun
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jun 14, 2023
…acebook#1030) Summary: - Requires RocksDB submodule to be up to or past 3f5c1236026233b34be64d597fe660d7e698f2f5 - Added new session variable to MyRocks rocksdb_create_temporary_checkpoint which will create a temporary RocksDB 'checkpoint' or 'snapshot'. If the session ends with an existing checkpoint, or if the variable is reset to another value, the checkpoint will get removed. - Added new session variable to MyRocks rocksdb_disable_file_deletions, which when set, will tell RocksDB to disable the deletion of old WAL and .sst files. If the session ends without re-enabling file deletion, file deletions will be explicitly re-enabled. - Expose rocksdb WAL position in i_s.log_status table. - Added tests to MyRocks for new options and behaviors. Pull Request resolved: facebook#1030 Differential Revision: D19487165 Pulled By: luqun
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Apr 9, 2024
…ercona#1030) Summary: - Requires RocksDB submodule to be up to or past 3f5c1236026233b34be64d597fe660d7e698f2f5 - Added new session variable to MyRocks rocksdb_create_temporary_checkpoint which will create a temporary RocksDB 'checkpoint' or 'snapshot'. If the session ends with an existing checkpoint, or if the variable is reset to another value, the checkpoint will get removed. - Added new session variable to MyRocks rocksdb_disable_file_deletions, which when set, will tell RocksDB to disable the deletion of old WAL and .sst files. If the session ends without re-enabling file deletion, file deletions will be explicitly re-enabled. - Expose rocksdb WAL position in i_s.log_status table. - Added tests to MyRocks for new options and behaviors. Pull Request resolved: facebook/mysql-5.6#1030 Differential Revision: D19487165 Pulled By: luqun
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires RocksDB submodule to be up to or past 3f5c1236026233b34be64d597fe660d7e698f2f5
Isolated all MyRocks 8 code chenges within #ifdef MYROCKS_8. Once this code
is unblocked, rocksdb.rocksdb will need to be re-recorded.
Added new session variable to MyRocks rocksdb_create_temporary_checkpoint
which will create a temporary RocksDB 'checkpoint' or 'snapshot'. If the
session ends with an existing checkpoint, or if the variable is reset to
another value, the checkpoint will get removed.
Added new session variable to MyRocks rocksdb_disable_file_deletions, which
when set, will tell RocksDB to disable the deletion of old WAL and .sst files.
If the session ends without re-enabling file deletion, file deletions will be
explicitly re-enabled.
Expose rocksdb WAL position in i_s.log_status table.
Added tests to MyRocks for new options and behaviors.