Skip to content

mysql-test/suite/rocksdb/t/add_index_inplace.test: fix race condition for finish_bulk_load #1252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
rockeet wants to merge 1 commit into
base: fb-mysql-8.0.28
Choose a base branch
from
Open

mysql-test/suite/rocksdb/t/add_index_inplace.test: fix race condition for finish_bulk_load #1252

rockeet wants to merge 1 commit into from
+4 −0

Conversation

@rockeet
Copy link
Contributor

@rockeet rockeet commented Nov 1, 2022

When client sees connection closed, finish_bulk_load in rocksdb_close_connection may still inprogress, the new connection created instantly following would racing with finish_bulk_load.

I can not fix the myrocks code for this race condition, but fix the test. set rocksdb_bulk_load will force calling finish_bulk_load and wait for finish_bulk_load ends.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed

2 participants

@rockeet @facebook-github-bot