This repository was archived by the owner on Mar 1, 2026. It is now read-only.
mysql-test/suite/rocksdb/t/add_index_inplace.test: fix race condition for finish_bulk_load#1252
Open
rockeet wants to merge 1 commit into
Open
mysql-test/suite/rocksdb/t/add_index_inplace.test: fix race condition for finish_bulk_load#1252rockeet wants to merge 1 commit into
rockeet wants to merge 1 commit into
Conversation
… for finish_bulk_load
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When client sees connection closed,
finish_bulk_loadinrocksdb_close_connectionmay still inprogress, the new connection created instantly following would racing with finish_bulk_load.I can not fix the myrocks code for this race condition, but fix the test. set rocksdb_bulk_load will force calling
finish_bulk_loadand wait forfinish_bulk_loadends.